Skip to content

Commit 5e14a3b

Browse files
committed
Move validators inside metrics package to make it more self contained.
1 parent ab46844 commit 5e14a3b

13 files changed

+23
-17
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerformance.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@
3434
import com.google.firebase.perf.logging.AndroidLogger;
3535
import com.google.firebase.perf.metrics.HttpMetric;
3636
import com.google.firebase.perf.metrics.Trace;
37+
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;
3738
import com.google.firebase.perf.transport.TransportManager;
3839
import com.google.firebase.perf.util.Constants;
3940
import com.google.firebase.perf.util.ImmutableBundle;
4041
import com.google.firebase.perf.util.Timer;
41-
import com.google.firebase.perf.validator.PerfMetricValidator;
4242
import com.google.firebase.remoteconfig.RemoteConfigComponent;
4343
import java.lang.annotation.Retention;
4444
import java.lang.annotation.RetentionPolicy;

firebase-perf/src/main/java/com/google/firebase/perf/metrics/HttpMetric.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import com.google.firebase.perf.config.ConfigResolver;
2222
import com.google.firebase.perf.impl.NetworkRequestMetricBuilder;
2323
import com.google.firebase.perf.logging.AndroidLogger;
24+
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;
2425
import com.google.firebase.perf.transport.TransportManager;
2526
import com.google.firebase.perf.util.Constants;
2627
import com.google.firebase.perf.util.Timer;
27-
import com.google.firebase.perf.validator.PerfMetricValidator;
2828
import java.net.URL;
2929
import java.util.AbstractMap;
3030
import java.util.HashMap;

firebase-perf/src/main/java/com/google/firebase/perf/metrics/Trace.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929
import com.google.firebase.perf.internal.SessionAwareObject;
3030
import com.google.firebase.perf.internal.SessionManager;
3131
import com.google.firebase.perf.logging.AndroidLogger;
32+
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;
3233
import com.google.firebase.perf.transport.TransportManager;
3334
import com.google.firebase.perf.util.Clock;
3435
import com.google.firebase.perf.util.Constants;
3536
import com.google.firebase.perf.util.Timer;
36-
import com.google.firebase.perf.validator.PerfMetricValidator;
3737
import java.lang.ref.WeakReference;
3838
import java.util.AbstractMap;
3939
import java.util.ArrayList;

firebase-perf/src/main/java/com/google/firebase/perf/validator/FirebasePerfApplicationInfoValidator.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/metrics/validator/FirebasePerfApplicationInfoValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import com.google.firebase.perf.logging.AndroidLogger;
1818
import com.google.firebase.perf.v1.ApplicationInfo;

firebase-perf/src/main/java/com/google/firebase/perf/validator/FirebasePerfGaugeMetricValidator.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/metrics/validator/FirebasePerfGaugeMetricValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import com.google.firebase.perf.v1.GaugeMetric;
1818
import com.google.firebase.perf.v1.PerfMetric;

firebase-perf/src/main/java/com/google/firebase/perf/validator/FirebasePerfNetworkValidator.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/metrics/validator/FirebasePerfNetworkValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import android.content.Context;
1818
import androidx.annotation.NonNull;

firebase-perf/src/main/java/com/google/firebase/perf/validator/FirebasePerfTraceValidator.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/metrics/validator/FirebasePerfTraceValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import androidx.annotation.NonNull;
1818
import androidx.annotation.Nullable;

firebase-perf/src/main/java/com/google/firebase/perf/validator/PerfMetricValidator.java renamed to firebase-perf/src/main/java/com/google/firebase/perf/metrics/validator/PerfMetricValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import android.content.Context;
1818
import androidx.annotation.NonNull;

firebase-perf/src/main/java/com/google/firebase/perf/transport/TransportManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import com.google.firebase.perf.internal.AppStateMonitor.AppStateCallback;
3737
import com.google.firebase.perf.internal.SessionManager;
3838
import com.google.firebase.perf.logging.AndroidLogger;
39+
import com.google.firebase.perf.metrics.validator.PerfMetricValidator;
3940
import com.google.firebase.perf.util.Constants;
4041
import com.google.firebase.perf.util.Constants.CounterNames;
4142
import com.google.firebase.perf.v1.AndroidApplicationInfo;
@@ -46,7 +47,6 @@
4647
import com.google.firebase.perf.v1.PerfMetric;
4748
import com.google.firebase.perf.v1.PerfMetricOrBuilder;
4849
import com.google.firebase.perf.v1.TraceMetric;
49-
import com.google.firebase.perf.validator.PerfMetricValidator;
5050
import java.lang.ref.WeakReference;
5151
import java.util.Collections;
5252
import java.util.Locale;
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818

@@ -24,7 +24,8 @@
2424
import org.robolectric.RobolectricTestRunner;
2525

2626
/**
27-
* Unit tests for {@link com.google.firebase.perf.validator.FirebasePerfApplicationInfoValidator}.
27+
* Unit tests for {@link
28+
* com.google.firebase.perf.metrics.validator.FirebasePerfApplicationInfoValidator}.
2829
*/
2930
@RunWith(RobolectricTestRunner.class)
3031
public class FirebasePerfApplicationInfoValidatorTest {

firebase-perf/src/test/java/com/google/firebase/perf/validator/FirebasePerfGaugeManagerValidatorTest.java renamed to firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfGaugeManagerValidatorTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818

@@ -27,7 +27,10 @@
2727
import org.junit.runner.RunWith;
2828
import org.robolectric.RobolectricTestRunner;
2929

30-
/** Unit tests for {@link com.google.firebase.perf.validator.FirebasePerfGaugeMetricValidator}. */
30+
/**
31+
* Unit tests for {@link
32+
* com.google.firebase.perf.metrics.validator.FirebasePerfGaugeMetricValidator}.
33+
*/
3134
@RunWith(RobolectricTestRunner.class)
3235
public final class FirebasePerfGaugeManagerValidatorTest {
3336

firebase-perf/src/test/java/com/google/firebase/perf/validator/FirebasePerfNetworkValidatorTest.java renamed to firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfNetworkValidatorTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static org.junit.Assert.assertFalse;
@@ -29,7 +29,9 @@
2929
import org.robolectric.RobolectricTestRunner;
3030
import org.robolectric.RuntimeEnvironment;
3131

32-
/** Unit tests for {@link com.google.firebase.perf.validator.FirebasePerfNetworkValidator}. */
32+
/**
33+
* Unit tests for {@link com.google.firebase.perf.metrics.validator.FirebasePerfNetworkValidator}.
34+
*/
3335
@RunWith(RobolectricTestRunner.class)
3436
public class FirebasePerfNetworkValidatorTest extends FirebasePerformanceTestBase {
3537
private final FirebasePerfNetworkValidator validator =

firebase-perf/src/test/java/com/google/firebase/perf/validator/FirebasePerfTraceValidatorTest.java renamed to firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfTraceValidatorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package com.google.firebase.perf.validator;
15+
package com.google.firebase.perf.metrics.validator;
1616

1717
import static com.google.common.truth.Truth.assertThat;
1818
import static org.mockito.Mockito.doAnswer;
@@ -39,7 +39,7 @@
3939
import org.mockito.stubbing.Answer;
4040
import org.robolectric.RobolectricTestRunner;
4141

42-
/** Unit tests for {@link com.google.firebase.perf.validator.FirebasePerfTraceValidator}. */
42+
/** Unit tests for {@link com.google.firebase.perf.metrics.validator.FirebasePerfTraceValidator}. */
4343
@RunWith(RobolectricTestRunner.class)
4444
public class FirebasePerfTraceValidatorTest extends FirebasePerformanceTestBase {
4545

0 commit comments

Comments
 (0)