Skip to content

Commit 5e78c1f

Browse files
committed
Use Java11 constructs for string concatenation.
1 parent 04a42c8 commit 5e78c1f

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfTraceValidatorTest.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -220,25 +220,17 @@ public void traceValidator_customAttributeEmptyKeyAndValue_marksPerfMetricInvali
220220

221221
@Test
222222
public void traceValidator_customAttributeWithLongKey_marksPerfMetricInvalid() {
223-
224-
StringBuilder longString = new StringBuilder();
225-
for (int i = 0; i <= Constants.MAX_ATTRIBUTE_KEY_LENGTH; i++) {
226-
longString.append("a");
227-
}
228223
TraceMetric.Builder trace =
229-
createValidTraceMetric().putCustomAttributes(longString.toString(), "value");
224+
createValidTraceMetric()
225+
.putCustomAttributes("a".repeat(Constants.MAX_ATTRIBUTE_KEY_LENGTH + 1), "value");
230226
assertThat(new FirebasePerfTraceValidator(trace.build()).isValidPerfMetric()).isFalse();
231227
}
232228

233229
@Test
234230
public void traceValidator_customAttributeWithLongValue_marksPerfMetricInvalid() {
235-
236-
StringBuilder longString = new StringBuilder();
237-
for (int i = 0; i <= Constants.MAX_ATTRIBUTE_VALUE_LENGTH; i++) {
238-
longString.append("a");
239-
}
240231
TraceMetric.Builder trace =
241-
createValidTraceMetric().putCustomAttributes("key", longString.toString());
232+
createValidTraceMetric()
233+
.putCustomAttributes("key", "a".repeat(Constants.MAX_ATTRIBUTE_VALUE_LENGTH + 1));
242234
assertThat(new FirebasePerfTraceValidator(trace.build()).isValidPerfMetric()).isFalse();
243235
}
244236

0 commit comments

Comments
 (0)