Copybara Storage: Fix Storage Lint (#504)

Author: schmidt-sebastian

firebase-storage/src/androidTest/java/com/google/firebase/storage/IntegrationTest.java

@@ -37,6 +37,7 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+/** Integration tests for {@link FirebaseStorage}. */
 @RunWith(AndroidJUnit4.class)
 public class IntegrationTest {
   @Rule

firebase-storage/src/test/java/com/google/firebase/storage/ListTest.java

@@ -32,6 +32,7 @@
 import org.robolectric.RobolectricTestRunner;
 import org.robolectric.annotation.Config;
 
+/** Tests for {@link FirebaseStorage}. */
 @RunWith(RobolectricTestRunner.class)
 @Config(sdk = Build.VERSION_CODES.LOLLIPOP_MR1)
 public class ListTest {
@@ -62,18 +63,21 @@ public void validateListOptions() {
       reference.list(-1);
       fail();
     } catch (IllegalArgumentException e) {
+      // Expected.
     }
 
     try {
       reference.list(1001);
       fail();
     } catch (IllegalArgumentException e) {
+      // Expected.
     }
 
     try {
       reference.list(1000, null);
       fail();
     } catch (IllegalArgumentException e) {
+      // Expected.
     }
   }
 

firebase-storage/src/test/java/com/google/firebase/storage/RetryRule.java

@@ -18,6 +18,7 @@
 import org.junit.runner.Description;
 import org.junit.runners.model.Statement;
 
+/** Retries tests that fail due to the test harnesses' unpredictable threading behavior. */
 public class RetryRule implements TestRule {
   private int retryCount;
 

firebase-storage/src/test/java/com/google/firebase/storage/network/NetworkLayerMock.java

@@ -14,6 +14,7 @@
 
 package com.google.firebase.storage.network;
 
+/** Installs the Network Mock used by the unit tests. */
 public class NetworkLayerMock {
   public static MockConnectionFactory ensureNetworkMock(String testName, boolean isBinary) {
     MockConnectionFactory mockConnectionFactory = new MockConnectionFactory(testName, isBinary);

firebase-storage/src/testUtil/java/com/google/firebase/storage/TestDownloadHelper.java

@@ -272,7 +272,8 @@ private static void verifyTaskCount(StorageReference reference, int expectedTask
         StorageTaskManager.getInstance().getDownloadTasksUnder(reference.getParent());
     Preconditions.checkState(
         downloadTasksAtParent.size() == expectedTasks,
-        "Expected active download task at location %s to contain %s item(s), but contained %s item(s)",
+        "Expected active download task at location %s to contain %s item(s), "
+            + "but contained %s item(s)",
         reference.getParent(),
         downloadTasksAtParent.size());
   }

firebase-storage/src/testUtil/java/com/google/firebase/storage/TestUploadHelper.java

@@ -694,7 +694,8 @@ private static void verifyTaskCount(StorageReference reference, int expectedTask
         StorageTaskManager.getInstance().getUploadTasksUnder(reference.getParent());
     Preconditions.checkState(
         uploadTasksAtParent.size() == expectedTasks,
-        "Expected active upload task at location %s to contain %s item(s), but contained %s item(s)",
+        "Expected active upload task at location %s to contain %s item(s), "
+            + "but contained %s item(s)",
         reference.getParent(),
         uploadTasksAtParent.size());
   }