skip invalid_base64_bitmap spec test

Author: milaGGL

firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SpecTestCase.java

@@ -478,14 +478,8 @@ private BloomFilter parseBloomFilter(JSONObject obj) throws JSONException {
     if (bits.has("padding")) {
       bitSequence.setPadding(bits.getInt("padding"));
     }
-    if (bits.has("bitmap")) {
-      try {
-        bitSequence.setBitmap(
-            ByteString.copyFrom(Base64.decode(bits.getString("bitmap"), Base64.DEFAULT)));
-      } catch (Exception e) {
-        bitSequence.setBitmap(ByteString.EMPTY);
-      }
-    }
+    bitSequence.setBitmap(
+        ByteString.copyFrom(Base64.decode(bits.getString("bitmap"), Base64.DEFAULT)));
 
     BloomFilter.Builder bloomFilter = BloomFilter.newBuilder();
     bloomFilter.setBits(bitSequence);

firebase-firestore/src/test/resources/json/existence_filter_spec_test.json

@@ -6413,6 +6413,8 @@
     "describeName": "Existence Filters:",
     "itName": "Full re-query is triggered when bloom filter bitmap is invalid",
     "tags": [
+      "no-ios",
+      "no-android"
     ],
     "config": {
       "numClients": 1,

firebase-firestore/src/testUtil/java/com/google/firebase/firestore/testutil/TestTargetMetadataProvider.java

@@ -30,7 +30,6 @@
 public class TestTargetMetadataProvider implements WatchChangeAggregator.TargetMetadataProvider {
   final Map<Integer, ImmutableSortedSet<DocumentKey>> syncedKeys = new HashMap<>();
   final Map<Integer, TargetData> queryData = new HashMap<>();
-  DatabaseId databaseId = null;
 
   @Override
   public ImmutableSortedSet<DocumentKey> getRemoteKeysForTarget(int targetId) {
@@ -45,17 +44,12 @@ public TargetData getTargetDataForTarget(int targetId) {
 
   @Override
   public DatabaseId getDatabaseId() {
-    return databaseId;
+    return DatabaseId.forProject("test-project");
   }
 
   /** Sets or replaces the local state for the provided query data. */
   public void setSyncedKeys(TargetData targetData, ImmutableSortedSet<DocumentKey> keys) {
     this.queryData.put(targetData.getTargetId(), targetData);
     this.syncedKeys.put(targetData.getTargetId(), keys);
   }
-
-  /** Sets or replaces the databaseId */
-  public void setDatabaseId(DatabaseId databaseId) {
-    this.databaseId = databaseId;
-  }
 }

firebase-firestore/src/testUtil/java/com/google/firebase/firestore/testutil/TestUtil.java

@@ -108,6 +108,8 @@ public class TestUtil {
 
   public static final long ARBITRARY_SEQUENCE_NUMBER = 2;
 
+  private static final DatabaseId TEST_PROJECT = DatabaseId.forProject("project");
+
   @SuppressWarnings("unchecked")
   public static <T> Map<String, T> map(Object... entries) {
     Map<String, T> res = new LinkedHashMap<>();
@@ -140,8 +142,7 @@ public static FieldMask fieldMask(String... fields) {
   public static final Map<String, Object> EMPTY_MAP = new HashMap<>();
 
   public static Value wrap(Object value) {
-    DatabaseId databaseId = DatabaseId.forProject("project");
-    UserDataReader dataReader = new UserDataReader(databaseId);
+    UserDataReader dataReader = new UserDataReader(TEST_PROJECT);
     // HACK: We use parseQueryValue() since it accepts scalars as well as arrays / objects, and
     // our tests currently use wrap() pretty generically so we don't know the intent.
     return dataReader.parseQueryValue(value);
@@ -491,7 +492,7 @@ public TargetData getTargetDataForTarget(int targetId) {
 
               @Override
               public DatabaseId getDatabaseId() {
-                return DatabaseId.forProject("test-project");
+                return TEST_PROJECT;
               }
             });
 
@@ -543,15 +544,15 @@ public TargetData getTargetDataForTarget(int targetId) {
 
               @Override
               public DatabaseId getDatabaseId() {
-                return DatabaseId.forProject("test-project");
+                return TEST_PROJECT;
               }
             });
     aggregator.handleDocumentChange(change);
     return aggregator.createRemoteEvent(doc.getVersion());
   }
 
   public static SetMutation setMutation(String path, Map<String, Object> values) {
-    UserDataReader dataReader = new UserDataReader(DatabaseId.forProject("project"));
+    UserDataReader dataReader = new UserDataReader(TEST_PROJECT);
     ParsedSetData parsed = dataReader.parseSetData(values);
 
     // The order of the transforms doesn't matter, but we sort them so tests can assume a particular
@@ -584,7 +585,7 @@ private static PatchMutation patchMutationHelper(
       }
     }
 
-    UserDataReader dataReader = new UserDataReader(DatabaseId.forProject("project"));
+    UserDataReader dataReader = new UserDataReader(TEST_PROJECT);
     ParsedUpdateData parsed = dataReader.parseUpdateData(values);
 
     // `mergeMutation()` provides an update mask for the merged fields, whereas `patchMutation()`