core review comments

Author: tejasd

firebase-perf/src/main/java/com/google/firebase/perf/logging/FirebaseSessionsEnforcementCheck.kt

@@ -25,6 +25,7 @@ class FirebaseSessionsEnforcementCheck {
     @JvmStatic var enforcement: Boolean = false
     private var logger: AndroidLogger = AndroidLogger.getInstance()
 
+    @JvmStatic
     fun checkSession(session: PerfSession, failureMessage: String) {
       if (session.isLegacy()) {
         logger.debug("legacy session ${session.sessionId()}: $failureMessage")

firebase-perf/src/main/java/com/google/firebase/perf/session/SessionManager.java

@@ -49,7 +49,7 @@ public static SessionManager getInstance() {
 
   /** Returns the currently active PerfSession. */
   public final PerfSession perfSession() {
-    FirebaseSessionsEnforcementCheck.Companion.checkSession(
+    FirebaseSessionsEnforcementCheck.checkSession(
         perfSession, "Access perf session from manger without aqs ready");
 
     return perfSession;
@@ -82,7 +82,7 @@ public void setApplicationContext(final Context appContext) {
    * @see PerfSession#isSessionRunningTooLong()
    */
   public void stopGaugeCollectionIfSessionRunningTooLong() {
-    FirebaseSessionsEnforcementCheck.Companion.checkSession(
+    FirebaseSessionsEnforcementCheck.checkSession(
         perfSession,
         "Session is not ready while trying to stopGaugeCollectionIfSessionRunningTooLong");
 
@@ -161,7 +161,7 @@ public void unregisterForSessionUpdates(WeakReference<SessionAwareObject> client
   }
 
   private void startOrStopCollectingGauges(ApplicationProcessState appState) {
-    FirebaseSessionsEnforcementCheck.Companion.checkSession(
+    FirebaseSessionsEnforcementCheck.checkSession(
         perfSession, "Session is not ready while trying to startOrStopCollectingGauges");
 
     if (perfSession.isGaugeAndEventCollectionEnabled()) {

firebase-perf/src/test/java/com/google/firebase/perf/session/FirebaseSessionsTestHelper.kt

@@ -24,6 +24,4 @@ fun createTestSession(suffix: Int): PerfSession {
   return PerfSession(testSessionId(suffix), Clock())
 }
 
-fun testSessionId(suffix: Int): String {
-  return "abc$suffix"
-}
+fun testSessionId(suffix: Int): String = "abc$suffix"