Skip to content

Commit 69d0641

Browse files
committed
Fix up some tests.
1 parent 5fc3cbc commit 69d0641

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

firebase-config/bandwagoner/src/androidTest/java/com/googletest/firebase/remoteconfig/bandwagoner/BandwagonerEspressoTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ public void activateFetchedWithoutFetching_activateFetchedReturnsFalse()
7474

7575
onView(withId(R.id.activate_fetched_button)).perform(click());
7676
onView(withId(R.id.api_call_results))
77-
.check(
78-
matches(withText(allOf(containsString("activateFetched"), containsString("false!")))));
77+
.check(matches(withText(allOf(containsString("activate"), containsString("false!")))));
7978
}
8079

8180
@Test
@@ -86,14 +85,11 @@ public void fetchAndActivateFetchedTwice_activateFetchedReturnsFalse()
8685

8786
onView(withId(R.id.activate_fetched_button)).perform(click());
8887
onView(withId(R.id.api_call_results))
89-
.check(
90-
matches(
91-
withText(allOf(containsString("activateFetched"), containsString("successful!")))));
88+
.check(matches(withText(allOf(containsString("activate"), containsString("successful!")))));
9289

9390
onView(withId(R.id.activate_fetched_button)).perform(click());
9491
onView(withId(R.id.api_call_results))
95-
.check(
96-
matches(withText(allOf(containsString("activateFetched"), containsString("false!")))));
92+
.check(matches(withText(allOf(containsString("activate"), containsString("false!")))));
9793
}
9894

9995
@Test

firebase-config/bandwagoner/src/main/java/com/googletest/firebase/remoteconfig/bandwagoner/ApiFragment.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
package com.googletest.firebase.remoteconfig.bandwagoner;
1818

19-
import static com.googletest.firebase.remoteconfig.bandwagoner.Constants.TAG;
2019
import static com.googletest.firebase.remoteconfig.bandwagoner.TimeFormatHelper.getCurrentTimeString;
2120

2221
import android.app.Activity;
2322
import android.os.Bundle;
23+
import android.text.TextUtils;
2424
import android.util.Log;
2525
import android.view.LayoutInflater;
2626
import android.view.View;
@@ -132,15 +132,21 @@ private void addListenerToButton(@IdRes int buttonResourceId, OnClickListener on
132132
}
133133

134134
/** Sets the version of the FRC server the SDK fetches from. */
135-
@SuppressWarnings("FirebaseUseExplicitDependencies")
136-
private Task<Void> onDevModeToggle(boolean isChecked) {
135+
private void onDevModeToggle(boolean isChecked) {
137136
hideSoftKeyboard();
138137

138+
FirebaseRemoteConfigSettings.Builder settingsBuilder =
139+
new FirebaseRemoteConfigSettings.Builder();
139140
String minimumFetchIntervalString = minimumFetchIntervalText.getText().toString();
140-
long fetchTimeout = isChecked ? 0L : Integer.valueOf(minimumFetchIntervalString);
141141

142-
return frc.setConfigSettingsAsync(
143-
new FirebaseRemoteConfigSettings.Builder().setFetchTimeoutInSeconds(fetchTimeout).build());
142+
if (isChecked || TextUtils.isEmpty(minimumFetchIntervalString)) {
143+
settingsBuilder.setMinimumFetchIntervalInSeconds(0L);
144+
} else {
145+
settingsBuilder.setMinimumFetchIntervalInSeconds(
146+
Integer.parseInt(minimumFetchIntervalString));
147+
}
148+
149+
frc.setConfigSettingsAsync(settingsBuilder.build());
144150
}
145151

146152
/**

firebase-config/src/androidTest/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigIntegrationTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ public void setDefaultsAsync_goodXml_setsDefaults() throws Exception {
128128
@Test
129129
public void setDefaultsAsync_emptyXml_setsEmptyDefaults() throws Exception {
130130
ConfigContainer emptyDefaultsXmlContainer = newDefaultsContainer(ImmutableMap.of());
131+
cachePutReturnsConfig(mockDefaultsCache, emptyDefaultsXmlContainer);
131132

132133
Task<Void> task = frc.setDefaultsAsync(getResourceId("frc_empty_defaults"));
133134
Tasks.await(task);
@@ -141,6 +142,7 @@ public void setDefaultsAsync_emptyXml_setsEmptyDefaults() throws Exception {
141142
public void setDefaultsAsync_badXml_ignoresBadEntries() throws Exception {
142143
ConfigContainer badDefaultsXmlContainer =
143144
newDefaultsContainer(ImmutableMap.of("second_default_key", "second_default_value"));
145+
cachePutReturnsConfig(mockDefaultsCache, badDefaultsXmlContainer);
144146

145147
Task<Void> task = frc.setDefaultsAsync(getResourceId("frc_bad_defaults"));
146148
Tasks.await(task);

0 commit comments

Comments
 (0)