Fix smoke test issues

Author: rlazo

build.gradle

@@ -58,11 +58,11 @@ ext {
     protobufJavaUtilVersion = libs.versions.protobufjavautil.get()
 }
 
+apply plugin: com.google.firebase.gradle.plugins.PublishingPlugin
+
 apply plugin: com.google.firebase.gradle.plugins.ci.ContinuousIntegrationPlugin
 apply plugin: com.google.firebase.gradle.plugins.ci.SmokeTestsPlugin
 
-apply plugin: com.google.firebase.gradle.plugins.PublishingPlugin
-
 firebaseContinuousIntegration {
     ignorePaths = [
             /.*\.gitignore$/,

buildSrc/src/main/java/com/google/firebase/gradle/plugins/LibraryGroups.kt

@@ -32,17 +32,19 @@ fun computeLibraryGroups(project: Project): Map<String, List<FirebaseLibraryExte
   val libraryGroups =
     project.subprojects.mapNotNull { it.firebaseLibraryOrNull }.groupBy { it.libraryGroupName }
 
-  // TODO(davidmotson): Confirm the right location for this functionality
-  for (libraryGroup in libraryGroups.values) {
+  return libraryGroups
+}
+
+fun fixLibraryGroupVersions(libraryGroups: Map<String, List<FirebaseLibraryExtension>>) {
+  for ((name, libraryGroup) in libraryGroups) {
     val maxVersion =
       libraryGroup.mapNotNull { it.moduleVersion }.maxOrNull()?.toString() ?: continue
-    for (library in libraryGroup) {
-      if (library.moduleVersion == null) {
-        library.project.version = maxVersion
+    for (firebaseExtension in libraryGroup) {
+      if (ModuleVersion.fromStringOrNull(firebaseExtension.project.version.toString()) == null) {
+        firebaseExtension.project.version = maxVersion.toString()
       }
     }
   }
-  return libraryGroups
 }
 
 /**

buildSrc/src/main/java/com/google/firebase/gradle/plugins/PublishingPlugin.kt

@@ -71,6 +71,7 @@ abstract class PublishingPlugin : Plugin<Project> {
     project.gradle.projectsEvaluated {
       val allFirebaseLibraries = project.subprojects.mapNotNull { it.firebaseLibraryOrNull }
       val libraryGroups = computeLibraryGroups(project)
+      fixLibraryGroupVersions(libraryGroups)
       val releaseMetadata = computeReleaseMetadata(project, allFirebaseLibraries, libraryGroups)
 
       val releasingFirebaseLibraries = releaseMetadata?.releasingLibraries.orEmpty()