Update API and fix tests

Author: Rachel Prince

firebase-appdistribution/api.txt

@@ -30,7 +30,6 @@ package com.google.firebase.appdistribution {
   }
 
   public enum FirebaseAppDistributionException.Status {
-    enum_constant public static final com.google.firebase.appdistribution.FirebaseAppDistributionException.Status APP_RUNNING_IN_PRODUCTION;
     enum_constant public static final com.google.firebase.appdistribution.FirebaseAppDistributionException.Status AUTHENTICATION_CANCELED;
     enum_constant public static final com.google.firebase.appdistribution.FirebaseAppDistributionException.Status AUTHENTICATION_FAILURE;
     enum_constant public static final com.google.firebase.appdistribution.FirebaseAppDistributionException.Status DOWNLOAD_FAILURE;

firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/ApkInstallerTests.java

@@ -85,7 +85,7 @@ public void installActivityDestroyed_setsInstallError() {
 
     assert ex instanceof FirebaseAppDistributionException;
     assertEquals(
-        "The APK failed to install or installation was cancelled",
+        FirebaseAppDistributionException.ErrorMessages.APK_INSTALLATION_FAILED,
         ((FirebaseAppDistributionException) ex).getMessage());
     assertEquals(
         FirebaseAppDistributionException.Status.INSTALLATION_FAILURE,

firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/FirebaseAppDistributionTesterApiClientTest.java

@@ -129,7 +129,8 @@ public void fetchNewRelease_whenConnectionFails_throwsError() throws Exception {
                     TEST_FID_1, TEST_APP_ID_1, TEST_API_KEY, TEST_AUTH_TOKEN, applicationContext));
 
     assertThat(ex.getErrorCode()).isEqualTo(Status.NETWORK_FAILURE);
-    assertThat(ex.getMessage()).contains("Failed to fetch releases due to unknown network error");
+    assertThat(ex.getMessage())
+        .contains(FirebaseAppDistributionException.ErrorMessages.NETWORK_ERROR);
     assertThat(ex.getCause()).isEqualTo(caughtException);
   }
 
@@ -146,7 +147,8 @@ public void fetchNewRelease_whenResponseFailsWith401_throwsError() throws Except
                     TEST_FID_1, TEST_APP_ID_1, TEST_API_KEY, TEST_AUTH_TOKEN, applicationContext));
 
     assertThat(ex.getErrorCode()).isEqualTo(Status.AUTHENTICATION_FAILURE);
-    assertThat(ex.getMessage()).isEqualTo("Failed to authenticate the tester");
+    assertThat(ex.getMessage())
+        .isEqualTo(FirebaseAppDistributionException.ErrorMessages.AUTHENTICATION_ERROR);
     verify(mockHttpsURLConnection).disconnect();
   }
 
@@ -163,7 +165,8 @@ public void fetchNewRelease_whenResponseFailsWith403_throwsError() throws Except
                     TEST_FID_1, TEST_APP_ID_1, TEST_API_KEY, TEST_AUTH_TOKEN, applicationContext));
 
     assertThat(ex.getErrorCode()).isEqualTo(Status.AUTHENTICATION_FAILURE);
-    assertThat(ex.getMessage()).isEqualTo("Failed to authorize the tester");
+    assertThat(ex.getMessage())
+        .isEqualTo(FirebaseAppDistributionException.ErrorMessages.AUTHORIZATION_ERROR);
     verify(mockHttpsURLConnection).disconnect();
   }
 
@@ -197,7 +200,8 @@ public void fetchNewRelease_whenResponseFailsWith504_throwsError() throws Except
                     TEST_FID_1, TEST_APP_ID_1, TEST_API_KEY, TEST_AUTH_TOKEN, applicationContext));
 
     assertThat(ex.getErrorCode()).isEqualTo(Status.NETWORK_FAILURE);
-    assertThat(ex.getMessage()).isEqualTo("Failed to fetch releases due to timeout");
+    assertThat(ex.getMessage())
+        .isEqualTo(FirebaseAppDistributionException.ErrorMessages.TIMEOUT_ERROR);
     verify(mockHttpsURLConnection).disconnect();
   }
 
@@ -232,7 +236,8 @@ public void fetchNewRelease_whenInvalidJson_throwsError() throws Exception {
                     TEST_FID_1, TEST_APP_ID_1, TEST_API_KEY, TEST_AUTH_TOKEN, applicationContext));
 
     assertThat(ex.getErrorCode()).isEqualTo(Status.UNKNOWN);
-    assertThat(ex.getMessage()).isEqualTo("Error parsing service response");
+    assertThat(ex.getMessage())
+        .isEqualTo(FirebaseAppDistributionException.ErrorMessages.JSON_PARSING_ERROR);
     assertThat(ex.getCause()).isInstanceOf(JSONException.class);
     verify(mockHttpsURLConnection).disconnect();
   }