Skip to content

Commit 765f9c8

Browse files
authored
Fix compiler warnings about checking permissions (#4188)
1 parent 7c5d077 commit 765f9c8

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

firebase-appdistribution/test-app/src/main/java/com/googletest/firebase/appdistribution/testapp/NotificationFeedbackTrigger.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import android.util.Log
1515
import androidx.activity.result.ActivityResultCaller
1616
import androidx.activity.result.contract.ActivityResultContracts
1717
import androidx.annotation.RequiresApi
18+
import androidx.annotation.RequiresPermission
1819
import androidx.core.app.NotificationCompat
1920
import androidx.core.app.NotificationManagerCompat
2021
import androidx.core.content.ContextCompat
@@ -124,7 +125,11 @@ object NotificationFeedbackTrigger : Application.ActivityLifecycleCallbacks {
124125
fun enable(activity: Activity) {
125126
activityToScreenshot = activity
126127
isEnabled = true
127-
showNotification(activity)
128+
if (ContextCompat.checkSelfPermission(activity, POST_NOTIFICATIONS) == PERMISSION_GRANTED) {
129+
showNotification(activity)
130+
} else {
131+
Log.w(TAG, "Not showing notification because permission has not been granted.")
132+
}
128133
}
129134

130135
/** Hide notifications. */
@@ -137,6 +142,7 @@ object NotificationFeedbackTrigger : Application.ActivityLifecycleCallbacks {
137142
activityToScreenshot = null
138143
}
139144

145+
@RequiresPermission(POST_NOTIFICATIONS)
140146
private fun showNotification(context: Context) {
141147
val intent = Intent(context, TakeScreenshotAndTriggerFeedbackActivity::class.java)
142148
intent.addFlags(Intent.FLAG_ACTIVITY_NO_HISTORY)

firebase-appdistribution/test-app/test-app.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ android {
2525
applicationId "com.googletest.firebase.appdistribution.testapp"
2626
minSdkVersion 23
2727
targetSdkVersion 33
28-
versionName "2.0"
29-
versionCode 2
28+
versionName "2.1"
29+
versionCode 3
3030

3131
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
3232
}

0 commit comments

Comments
 (0)