Simplify proguard handling logic. (#2744)

* Simplify proguard handling logic.

This change removes custom logic that configures proguarding and
consumerProguardFiles for SDKs and instead makes all configuration
explicit per SDK.

* Fix

Author: vkryachko

build.gradle

@@ -101,55 +101,6 @@ configure(subprojects) {
     apply plugin: "org.jlleitschuh.gradle.ktlint"
 }
 
-
-/**
- * Configure "Preguarding" for the subprojects.
- *
- * <p> The way it works is every library subproject that has the android plugin applied and:
- *
- *  <ul>
- *    <li>Contains a file named "preguard.txt" will get proguarded using that file as proguard
- *        configuration in release mode.
- *    <li>Contains a file named "proguard.txt" will ship this file inside its release aar as a
- *        consumer proguard file.
- */
-configure(subprojects) {
-    def PREGUARD_FILE_NAME = 'preguard.txt'
-    def CONSUMER_PROGUARD_FILE_NAME = 'proguard.txt'
-    afterEvaluate { Project sub ->
-
-        if (sub.plugins.findPlugin('com.android.library') == null) {
-            return
-        }
-
-        boolean skipPreguard = sub.getProperties().getOrDefault('firebaseSkipPreguard', 'true').toBoolean()
-        def defaultPreguard = rootProject.getProperties().getOrDefault('firebaseDefaultPreguardFile', 'default-preguard.txt')
-
-        if(!skipPreguard) {
-
-            sub.android {
-                buildTypes {
-                    release {
-                        // default behavior for minifyEnabled is:
-                        // useProguard true
-                        // shrinkResources false
-                        minifyEnabled true
-                        proguardFiles file(defaultPreguard), sub.file(PREGUARD_FILE_NAME)
-                    }
-                }
-            }
-        }
-
-        // Ship consumer proguard config if it exists.
-        if (sub.file(CONSUMER_PROGUARD_FILE_NAME).exists()) {
-            sub.android { buildTypes { release { consumerProguardFiles 'proguard.txt' } } }
-        }
-
-        sub.apply plugin: LicenseResolverPlugin
-    }
-}
-
-
 task clean(type: Delete) {
     delete rootProject.buildDir
 }

buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.java

@@ -25,6 +25,7 @@
 import com.google.firebase.gradle.plugins.apiinfo.GetMetalavaJarTask;
 import com.google.firebase.gradle.plugins.ci.Coverage;
 import com.google.firebase.gradle.plugins.ci.device.FirebaseTestServer;
+import com.google.firebase.gradle.plugins.license.LicenseResolverPlugin;
 import java.io.File;
 import java.nio.file.Paths;
 import org.gradle.api.JavaVersion;
@@ -40,6 +41,7 @@ public class FirebaseLibraryPlugin implements Plugin<Project> {
   @Override
   public void apply(Project project) {
     project.apply(ImmutableMap.of("plugin", "com.android.library"));
+    project.apply(ImmutableMap.of("plugin", LicenseResolverPlugin.class));
 
     FirebaseLibraryExtension firebaseLibrary =
         project

buildSrc/src/main/java/com/google/firebase/gradle/plugins/license/LicenseResolverPlugin.java

@@ -40,7 +40,7 @@
  *       GenerateLicensesTask} to create the artifacts necessary for our release.
  * </ul>
  */
-class LicenseResolverPlugin implements Plugin<Project> {
+public class LicenseResolverPlugin implements Plugin<Project> {
   private static final String[] ANDROID_PLUGINS = {
     "com.android.application", "com.android.library", "com.android.test"
   };

encoders/firebase-encoders-json/proguard.txt

@@ -33,6 +33,7 @@ android {
       versionName version
       multiDexEnabled true
       testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+      consumerProguardFiles 'proguard.txt'
     }
     sourceSets {
         androidTest {

firebase-common/firebase-common.gradle

@@ -27,6 +27,7 @@ android {
       targetSdkVersion project.targetSdkVersion
       versionName version
       testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+      consumerProguardFiles 'proguard.txt'
     }
 
     compileOptions {

firebase-common/mapping.txt

@@ -58,6 +58,7 @@ android {
         versionName version
         multiDexEnabled true
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+        consumerProguardFiles 'proguard.txt'
     }
 
     sourceSets {

firebase-components/firebase-components.gradle

@@ -33,6 +33,7 @@ android {
         versionName version
         multiDexEnabled true
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+        consumerProguardFiles 'proguard.txt'
     }
     sourceSets {
         androidTest {

firebase-database-collection/mapping.txt

@@ -59,6 +59,7 @@ android {
       multiDexEnabled true
       versionName version
       testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+      consumerProguardFiles 'proguard.txt'
     }
     sourceSets {
         main {

firebase-database-collection/preguard.txt

@@ -26,6 +26,7 @@ android {
         minSdkVersion 14
         targetSdkVersion project.targetSdkVersion
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+        consumerProguardFiles 'proguard.txt'
     }
 
     compileOptions {

firebase-database/proguard.txt

@@ -43,6 +43,7 @@ android {
         targetSdkVersion project.targetSdkVersion
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         versionName version
+        consumerProguardFiles 'proguard.txt'
     }
     compileOptions {
         sourceCompatibility = '1.8'