Skip to content

Commit 7c58599

Browse files
committed
Add comments and update tests
1 parent 6c2aaa4 commit 7c58599

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandler.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -575,6 +575,8 @@ public static FetchResponse forBackendUpdatesFetched(
575575
lastFetchETag);
576576
}
577577

578+
// Passing in param fetchedConfigs because it contains templateVersion but no other active
579+
// fields.
578580
public static FetchResponse forBackendHasNoUpdates(
579581
Date fetchTime, ConfigContainer fetchedConfigs) {
580582
return new FetchResponse(

firebase-config/src/test/java/com/google/firebase/remoteconfig/internal/ConfigFetchHttpClientTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,13 +161,15 @@ public void fetch_newValues_responseSet() throws Exception {
161161
}
162162

163163
@Test
164-
public void fetch_noChange_responseNotSet() throws Exception {
164+
public void fetch_noChange_responseOnlyContainsTemplateVersion() throws Exception {
165165
setServerResponseTo(noChangeResponseBody, SECOND_ETAG);
166166

167167
FetchResponse response = fetch(SECOND_ETAG);
168168

169169
assertThat(response.getLastFetchETag()).isNull();
170170
assertThat(response.getFetchedConfigs()).isNotNull();
171+
assertThat(response.getFetchedConfigs().getTemplateVersionNumber()).isNotNull();
172+
assertThat(response.getFetchedConfigs().getConfigs().length()).isEqualTo(0);
171173
}
172174

173175
@Test

0 commit comments

Comments
 (0)