Skip to content

Commit 8059757

Browse files
committed
Feedback
1 parent 470f637 commit 8059757

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/FirebaseCrashlytics.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public class FirebaseCrashlytics {
161161

162162
final String googleAppId = app.getOptions().getApplicationId();
163163
final String mappingFileId = CommonUtils.getMappingFileId(context);
164-
Logger.getLogger().v("Mapping file ID is: " + mappingFileId);
164+
Logger.getLogger().d("Mapping file ID is: " + mappingFileId);
165165

166166
final UnityVersionProvider unityVersionProvider = new ResourceUnityVersionProvider(context);
167167

@@ -282,7 +282,7 @@ public static FirebaseCrashlytics getInstance() {
282282
*/
283283
public void recordException(@NonNull Throwable throwable) {
284284
if (throwable == null) { // Users could call this with null despite the annotation.
285-
Logger.getLogger().v("A null value was passed to recordException. Ignoring.");
285+
Logger.getLogger().w("A null value was passed to recordException. Ignoring.");
286286
return;
287287
}
288288
core.logException(throwable);

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsUncaughtExceptionHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ public void uncaughtException(Thread thread, Throwable ex) {
5656
} catch (Exception e) {
5757
Logger.getLogger().e("An error occurred in the uncaught exception handler", e);
5858
} finally {
59-
Logger.getLogger()
60-
.d("Completed exception processing." + " Invoking default exception handler.");
59+
Logger.getLogger().d("Completed exception processing. Invoking default exception handler.");
6160
defaultHandler.uncaughtException(thread, ex);
6261
isHandlingException.set(false);
6362
}

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/DataCollectionArbiter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ private void logDataCollectionState(boolean dataCollectionEnabled) {
142142
? "global Firebase setting"
143143
: setInManifest ? FIREBASE_CRASHLYTICS_COLLECTION_ENABLED + " manifest flag" : "API";
144144
Logger.getLogger()
145-
.v(
145+
.d(
146146
String.format(
147147
"Crashlytics automatic data collection %s by %s.", stateString, fromString));
148148
}

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/settings/network/DefaultSettingsSpiCall.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ JSONObject handleResponse(HttpResponse httpResponse) {
128128
if (requestWasSuccessful(statusCode)) {
129129
toReturn = getJsonObjectFrom(httpResponse.body());
130130
} else {
131-
logger.e("Failed to retrieve settings from " + url);
131+
logger.e("Settings request failed; (status: " + statusCode + ") from " + url);
132132
toReturn = null;
133133
}
134134
return toReturn;

0 commit comments

Comments
 (0)