Skip to content

Commit 80b3366

Browse files
committed
Don't generate whole Session Start event for sampled event
1 parent 39fbdff commit 80b3366

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,16 @@ internal constructor(
6161

6262
private fun initiateSessionStart() {
6363
val sessionDetails = sessionGenerator.generateNewSession()
64-
val sessionEvent =
65-
SessionEvents.startSession(firebaseApp, sessionDetails, sessionSettings, timeProvider)
6664

6765
if (!sessionGenerator.collectEvents) {
66+
// TODO(mrober): Make log levels/messages consistent with iOS
6867
Log.d(TAG, "Session Start event sampled.")
6968
return
7069
}
7170

72-
sessionCoordinator.attemptLoggingSessionEvent(sessionEvent)
71+
sessionCoordinator.attemptLoggingSessionEvent(
72+
SessionEvents.startSession(firebaseApp, sessionDetails, sessionSettings, timeProvider)
73+
)
7374
}
7475

7576
/** Calculate whether we should sample events using [sessionSettings] data. */

0 commit comments

Comments
 (0)