Skip to content

Commit 8a21319

Browse files
authored
Hides the constructors for FirebaseAppDistributionException. (#3745)
The constructors need to be public, because they are called from other packages (i.e. internal/impl). But there is no reason for customers to create these exceptions themselves. So having them show up in JavaDoc is confusing and not helpful.
1 parent bd761a7 commit 8a21319

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

firebase-appdistribution-api/api.txt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ package com.google.firebase.appdistribution {
2424
}
2525

2626
public class FirebaseAppDistributionException extends com.google.firebase.FirebaseException {
27-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status);
28-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status, @Nullable com.google.firebase.appdistribution.AppDistributionRelease);
29-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status, @NonNull Throwable);
30-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status, @Nullable com.google.firebase.appdistribution.AppDistributionRelease, @NonNull Throwable);
3127
method @NonNull public com.google.firebase.appdistribution.FirebaseAppDistributionException.Status getErrorCode();
3228
method @Nullable public com.google.firebase.appdistribution.AppDistributionRelease getRelease();
3329
}
@@ -50,8 +46,8 @@ package com.google.firebase.appdistribution {
5046
}
5147

5248
public interface UpdateProgress {
53-
method @NonNull public long getApkBytesDownloaded();
54-
method @NonNull public long getApkFileTotalBytes();
49+
method public long getApkBytesDownloaded();
50+
method public long getApkFileTotalBytes();
5551
method @NonNull public com.google.firebase.appdistribution.UpdateStatus getUpdateStatus();
5652
}
5753

firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistributionException.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,22 +83,26 @@ public enum Status {
8383
@NonNull private final Status status;
8484
@Nullable private final AppDistributionRelease release;
8585

86+
/** @hide */
8687
public FirebaseAppDistributionException(@NonNull String message, @NonNull Status status) {
8788
this(message, status, (AppDistributionRelease) null);
8889
}
8990

91+
/** @hide */
9092
public FirebaseAppDistributionException(
9193
@NonNull String message, @NonNull Status status, @Nullable AppDistributionRelease release) {
9294
super(message);
9395
this.status = status;
9496
this.release = release;
9597
}
9698

99+
/** @hide */
97100
public FirebaseAppDistributionException(
98101
@NonNull String message, @NonNull Status status, @NonNull Throwable cause) {
99102
this(message, status, null, cause);
100103
}
101104

105+
/** @hide */
102106
public FirebaseAppDistributionException(
103107
@NonNull String message,
104108
@NonNull Status status,

0 commit comments

Comments
 (0)