Skip to content

Commit 8a51a73

Browse files
committed
Final review nits
1 parent 2d67b78 commit 8a51a73

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

firebase-common/src/main/java/com/google/firebase/FirebaseApp.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public class FirebaseApp {
112112
private final ComponentRuntime componentRuntime;
113113

114114
private final AtomicBoolean emulatorSettingsFrozen = new AtomicBoolean(false);
115-
private EmulatorSettings emulatorSettings = EmulatorSettings.getDefault();
115+
private EmulatorSettings emulatorSettings = EmulatorSettings.DEFAULT;
116116

117117
// Default disabled. We released Firebase publicly without this feature, so making it default
118118
// enabled is a backwards incompatible change.

firebase-common/src/main/java/com/google/firebase/emulators/EmulatorSettings.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@
3333
public final class EmulatorSettings {
3434

3535
/** Empty emulator settings to be used as an internal default */
36-
public static EmulatorSettings getDefault() {
37-
return new EmulatorSettings.Builder().build();
38-
}
36+
public static final EmulatorSettings DEFAULT = new EmulatorSettings.Builder().build();
3937

4038
public static final class Builder {
4139

firebase-common/src/main/java/com/google/firebase/emulators/FirebaseEmulator.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*/
2929
public final class FirebaseEmulator {
3030

31-
public final String name;
31+
private final String name;
3232

3333
/**
3434
* Only to be called by SDKs which support emulators in order to make constants.
@@ -43,4 +43,8 @@ public static FirebaseEmulator forName(String name) {
4343
private FirebaseEmulator(String name) {
4444
this.name = name;
4545
}
46+
47+
public String getName() {
48+
return name;
49+
}
4650
}

0 commit comments

Comments
 (0)