Skip to content

Commit 8cb30c1

Browse files
authored
Add float support to ValueEncoderContext. (#2208)
* Add float support to ValueEncoderContext. Important for future protobuf support. * Update api.txt
1 parent 13b12ca commit 8cb30c1

File tree

3 files changed

+13
-0
lines changed

3 files changed

+13
-0
lines changed

encoders/firebase-encoders-json/src/main/java/com/google/firebase/encoders/json/JsonValueObjectEncoderContext.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,14 @@ public JsonValueObjectEncoderContext add(@Nullable String value) throws IOExcept
171171
return this;
172172
}
173173

174+
@NonNull
175+
@Override
176+
public JsonValueObjectEncoderContext add(float value) throws IOException {
177+
maybeUnNest();
178+
jsonWriter.value(value);
179+
return this;
180+
}
181+
174182
@NonNull
175183
@Override
176184
public JsonValueObjectEncoderContext add(double value) throws IOException {

encoders/firebase-encoders/api.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ package com.google.firebase.encoders {
5151

5252
public interface ValueEncoderContext {
5353
method @NonNull public com.google.firebase.encoders.ValueEncoderContext add(@Nullable String);
54+
method @NonNull public com.google.firebase.encoders.ValueEncoderContext add(float);
5455
method @NonNull public com.google.firebase.encoders.ValueEncoderContext add(double);
5556
method @NonNull public com.google.firebase.encoders.ValueEncoderContext add(int);
5657
method @NonNull public com.google.firebase.encoders.ValueEncoderContext add(long);

encoders/firebase-encoders/src/main/java/com/google/firebase/encoders/ValueEncoderContext.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ public interface ValueEncoderContext {
3030
@NonNull
3131
ValueEncoderContext add(@Nullable String value) throws IOException;
3232

33+
/** Adds {@code value} as a primitive encoded value. */
34+
@NonNull
35+
ValueEncoderContext add(float value) throws IOException;
36+
3337
/** Adds {@code value} as a primitive encoded value. */
3438
@NonNull
3539
ValueEncoderContext add(double value) throws IOException;

0 commit comments

Comments
 (0)