Resolve comments. Revert FirebaseCrashlytics api change, the plugin will call from core directly.

Author: mrober

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/FirebaseCrashlytics.java

@@ -201,16 +201,6 @@ public void recordException(@NonNull Throwable throwable) {
     core.logException(throwable);
   }
 
-  /** Records a fatal report and sends to Crashlytics on-demand. */
-  // TODO(mrober): Move this to a FirebaseCrashlyticsInternal interface.
-  private void recordFatalException(Throwable throwable) {
-    if (throwable == null) {
-      Logger.getLogger().w("A null value was passed to recordFatalException. Ignoring.");
-      return;
-    }
-    core.logFatalException(throwable);
-  }
-
   /**
    * Logs a message that's included in the next fatal, non-fatal, or ANR report.
    *

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/OnDemandCounter.java

@@ -14,33 +14,35 @@
 
 package com.google.firebase.crashlytics.internal.common;
 
+import java.util.concurrent.atomic.AtomicInteger;
+
 /** Simple, thread-safe, class to keep count of recorded and dropped on-demand events. */
 public final class OnDemandCounter {
-  private int recordedOnDemandExceptions;
-  private int droppedOnDemandExceptions;
+  private final AtomicInteger recordedOnDemandExceptions;
+  private final AtomicInteger droppedOnDemandExceptions;
 
   public OnDemandCounter() {
-    recordedOnDemandExceptions = 0;
-    droppedOnDemandExceptions = 0;
+    recordedOnDemandExceptions = new AtomicInteger();
+    droppedOnDemandExceptions = new AtomicInteger();
   }
 
-  public synchronized int getRecordedOnDemandExceptions() {
-    return recordedOnDemandExceptions;
+  public int getRecordedOnDemandExceptions() {
+    return recordedOnDemandExceptions.get();
   }
 
-  public synchronized void incrementRecordedOnDemandExceptions() {
-    recordedOnDemandExceptions++;
+  public void incrementRecordedOnDemandExceptions() {
+    recordedOnDemandExceptions.getAndIncrement();
   }
 
-  public synchronized int getDroppedOnDemandExceptions() {
-    return droppedOnDemandExceptions;
+  public int getDroppedOnDemandExceptions() {
+    return droppedOnDemandExceptions.get();
   }
 
-  public synchronized void incrementDroppedOnDemandExceptions() {
-    droppedOnDemandExceptions++;
+  public void incrementDroppedOnDemandExceptions() {
+    droppedOnDemandExceptions.getAndIncrement();
   }
 
-  public synchronized void resetDroppedOnDemandExceptions() {
-    droppedOnDemandExceptions = 0;
+  public void resetDroppedOnDemandExceptions() {
+    droppedOnDemandExceptions.set(0);
   }
 }

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/send/ReportQueue.java

@@ -14,8 +14,6 @@
 
 package com.google.firebase.crashlytics.internal.send;
 
-import static com.google.firebase.components.Preconditions.checkState;
-
 import com.google.android.datatransport.Event;
 import com.google.android.datatransport.Transport;
 import com.google.android.gms.tasks.TaskCompletionSource;
@@ -139,8 +137,6 @@ private boolean isQueueAvailable() {
   }
 
   private boolean isQueueFull() {
-    // TODO(mrober): Remove this after testing.
-    checkState(queue.size() <= queueCapacity, "Queue went over capacity. Concurrency issue?");
     return queue.size() == queueCapacity;
   }