Skip to content

Commit 93a44a7

Browse files
committed
Fix query to pipeline logic.
1 parent d452eb3 commit 93a44a7

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryToPipelineTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ public void testQueriesCanUseNotEqualFilters() {
356356
expectedDocsMap.remove("i");
357357
expectedDocsMap.remove("j");
358358
snapshot =
359-
waitFor(db.pipeline().convertFrom(collection.whereEqualTo("zip", Double.NaN)).execute());
359+
waitFor(db.pipeline().convertFrom(collection.whereNotEqualTo("zip", Double.NaN)).execute());
360360
assertEquals(Lists.newArrayList(expectedDocsMap.values()), pipelineSnapshotToValues(snapshot));
361361
}
362362

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/testutil/IntegrationTestUtil.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -567,9 +567,18 @@ public static void checkOnlineAndOfflineResultsMatch(Query query, String... expe
567567
* @param expectedDocs Ordered list of document keys that are expected to match the query
568568
*/
569569
public static void checkQueryAndPipelineResultsMatch(Query query, String... expectedDocs) {
570-
QuerySnapshot docsFromQuery = waitFor(query.get(Source.SERVER));
571-
PipelineSnapshot docsFromPipeline =
572-
waitFor(query.getFirestore().pipeline().convertFrom(query).execute());
570+
QuerySnapshot docsFromQuery;
571+
try {
572+
docsFromQuery = waitFor(query.get(Source.SERVER));
573+
} catch (Exception e) {
574+
throw new RuntimeException("Classic Query FAILED", e);
575+
}
576+
PipelineSnapshot docsFromPipeline;
577+
try {
578+
docsFromPipeline = waitFor(query.getFirestore().pipeline().convertFrom(query).execute());
579+
} catch (Exception e) {
580+
throw new RuntimeException("Pipeline FAILED", e);
581+
}
573582

574583
assertEquals(querySnapshotToIds(docsFromQuery), pipelineSnapshotToIds(docsFromPipeline));
575584
List<String> expected = asList(expectedDocs);

0 commit comments

Comments
 (0)