Skip to content

Commit 94c91fc

Browse files
committed
Removed comment
1 parent e60273c commit 94c91fc

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

firebase-database/src/main/java/com/google/firebase/database/core/persistence/DefaultPersistenceManager.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ public CacheNode serverCache(QuerySpec query) {
157157
}
158158

159159
// TODO[persistence]: Only load the tracked key data rather than load everything and then filter
160-
// We could pass the query id to the
161160
Node serverCacheNode = storageLayer.serverCache(query.getPath());
162161
if (trackedKeys != null) {
163162
Node filteredNode = EmptyNode.Empty();

firebase-database/src/main/java/com/google/firebase/database/core/view/View.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ public Node getCompleteServerCache(Path path) {
101101
if (cache != null) {
102102
// If this isn't a "loadsAllData" view, then cache isn't actually a complete cache and
103103
// we need to see if it contains the child we're interested in.
104+
// Clarify: just because this is a loadsAllData() doesn't mean that it'll contain the child,
105+
// right?
104106
if (this.query.loadsAllData()
105107
|| (!path.isEmpty() && !cache.getImmediateChild(path.getFront()).isEmpty())) {
106108
return cache.getChild(path);

0 commit comments

Comments
 (0)