Kotlin implementation for Https callable functions

Author: sam-gc

firebase-functions/ktx/ktx.gradle.kts

@@ -59,4 +59,5 @@ dependencies {
   testImplementation(libs.junit)
   testImplementation(libs.truth)
   testImplementation(libs.androidx.test.core)
+  testImplementation(project(":firebase-functions"))
 }

firebase-functions/ktx/src/main/kotlin/com/google/firebase/functions/ktx/Functions.kt

@@ -19,8 +19,11 @@ import com.google.firebase.FirebaseApp
 import com.google.firebase.components.Component
 import com.google.firebase.components.ComponentRegistrar
 import com.google.firebase.functions.FirebaseFunctions
+import com.google.firebase.functions.HttpsCallableOptions
+import com.google.firebase.functions.HttpsCallableReference
 import com.google.firebase.ktx.Firebase
 import com.google.firebase.platforminfo.LibraryVersionComponent
+import java.net.URL
 
 /** Returns the [FirebaseFunctions] instance of the default [FirebaseApp]. */
 val Firebase.functions: FirebaseFunctions
@@ -45,3 +48,15 @@ class FirebaseFunctionsKtxRegistrar : ComponentRegistrar {
   override fun getComponents(): List<Component<*>> =
     listOf(LibraryVersionComponent.create(LIBRARY_NAME, BuildConfig.VERSION_NAME))
 }
+
+fun FirebaseFunctions.getHttpsCallable(name: String, init: HttpsCallableOptions.Builder.() -> Unit) : HttpsCallableReference {
+  val builder = HttpsCallableOptions.Builder()
+  builder.init()
+  return getHttpsCallable(name, builder.build())
+}
+
+fun FirebaseFunctions.getHttpsCallableFromUrl(url: URL, init: HttpsCallableOptions.Builder.() -> Unit) : HttpsCallableReference {
+  val builder = HttpsCallableOptions.Builder()
+  builder.init()
+  return getHttpsCallableFromUrl(url, builder.build())
+}

firebase-functions/ktx/src/test/kotlin/com/google/firebase/functions/ktx/FunctionsTests.kt

@@ -19,6 +19,8 @@ import com.google.common.truth.Truth.assertThat
 import com.google.firebase.FirebaseApp
 import com.google.firebase.FirebaseOptions
 import com.google.firebase.functions.FirebaseFunctions
+import com.google.firebase.functions.HttpsCallableReference
+import com.google.firebase.functions.TestVisibilityUtil
 import com.google.firebase.ktx.Firebase
 import com.google.firebase.ktx.app
 import com.google.firebase.ktx.initialize
@@ -28,6 +30,8 @@ import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
+import java.lang.reflect.Field
+import java.net.URL
 
 const val APP_ID = "APP_ID"
 const val API_KEY = "API_KEY"
@@ -100,3 +104,38 @@ class LibraryVersionTest : BaseTestCase() {
     assertThat(publisher.userAgent).contains(LIBRARY_NAME)
   }
 }
+
+@RunWith(RobolectricTestRunner::class)
+class AppCheckLimitedUseTest : BaseTestCase() {
+  @Test
+  fun `FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)`() {
+    val callable = Firebase.functions.getHttpsCallable("function") {
+      limitedUseAppCheckTokens = true
+    };
+    assertThat(TestVisibilityUtil.refUsesLimitedUseFacTokens(callable)).isEqualTo(true)
+  }
+
+//  @Test
+//  fun `FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)`() {
+//    val callable = Firebase.functions.getHttpsCallable("function") {
+//      limitedUseAppCheckTokens = false
+//    };
+//    assertLimitedUseFACTokens(callable, false)
+//  }
+//
+//  @Test
+//  fun `FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)`() {
+//    val callable = Firebase.functions.getHttpsCallableFromUrl(URL()) {
+//      limitedUseAppCheckTokens = true
+//    };
+//    assertLimitedUseFACTokens(callable, true)
+//  }
+//
+//  @Test
+//  fun `FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)`() {
+//    val callable = Firebase.functions.getHttpsCallable("function") {
+//      limitedUseAppCheckTokens = false
+//    };
+//    assertLimitedUseFACTokens(callable, false)
+//  }
+}

firebase-functions/src/test/java/com/google/firebase/functions/TestVisibilityUtil.java

@@ -0,0 +1,13 @@
+package com.google.firebase.functions;
+
+/** Exposes fields for testing from Kotlin, which is in a different package */
+public final class TestVisibilityUtil {
+  private TestVisibilityUtil() {}
+
+  /**
+   * Returns true if the {@link HttpsCallableReference} is configured to use FAC limited-use tokens.
+   */
+  public static boolean refUsesLimitedUseFacTokens(HttpsCallableReference ref) {
+    return ref.options.getLimitedUseAppCheckTokens();
+  }
+}