Add in-app feedback requests to FirebaseAppDistributionTesterApiClient (#3778)

* Add in-app feedback requests to FirebaseAppDistributionTesterApiClient

Also refactors out low level API-specific HTTP and basic JSON parsing functionality into TesterApiHttpClient

* Refactor error handling based on Kai's feedback

* Chage test project id

* ./gradlew :firebase-appdistribution:ktlintFormat :firebase-appdistribution:ktlintFormat :firebase-appdistribution-api:googleJavaFormat :firebase-appdistribution:googleJavaFormat

Co-authored-by: Kai Bolay <[email protected]>

Author: lfkellogg

firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistributionException.java

@@ -26,8 +26,9 @@ public enum Status {
     UNKNOWN,
 
     /**
-     * The authentication process failed. The tester was either not signed in, or something went
-     * wrong. Try signing in again by calling {@link FirebaseAppDistribution#signInTester}.
+     * The authentication process failed. The tester was either not signed in, does not have access,
+     * or something went wrong. Try signing in again by calling {@link
+     * FirebaseAppDistribution#signInTester}.
      */
     AUTHENTICATION_FAILURE,
 

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/ErrorMessages.java

@@ -18,7 +18,9 @@ class ErrorMessages {
   static final String NETWORK_ERROR = "Request failed with unknown network error.";
 
   static final String JSON_PARSING_ERROR =
-      "Error parsing service response when checking for new release. This was most likely due to a transient condition and may be corrected by retrying.";
+      "Error parsing service response. This was most likely due to a transient condition and may be corrected by retrying.";
+
+  static final String JSON_SERIALIZATION_ERROR = "Error building request body.";
 
   static final String AUTHENTICATION_ERROR =
       "Failed to authenticate the tester. The tester was either not signed in, or something went wrong. Try signing in again.";
@@ -28,8 +30,10 @@ class ErrorMessages {
 
   static final String AUTHENTICATION_CANCELED = "Tester canceled the authentication flow.";
 
-  static final String NOT_FOUND_ERROR =
-      "Release not found. An update was not available for the current tester and app. Make sure that FirebaseAppDistribution#checkForNewRelease returns with a non-null  AppDistributionRelease before calling FirebaseAppDistribution#updateApp";
+  static final String RELEASE_NOT_FOUND_ERROR =
+      "Release not found. An update was not available for the current tester and app. Make sure that checkForNewRelease() returns with a non-null AppDistributionRelease before calling updateApp()";
+
+  static final String NOT_FOUND_ERROR = "Resource not found (or the tester may not have access).";
 
   static final String TIMEOUT_ERROR =
       "Request timed out. Check the tester's internet connection and try again.";
@@ -42,7 +46,7 @@ class ErrorMessages {
       "Download URL not found. This was a most likely due to a transient condition and may be corrected by retrying.";
 
   static final String HOST_ACTIVITY_INTERRUPTED =
-      "Host activity interrupted while dialog was showing. Try calling FirebaseAppDistribution#updateIfNewReleaseAvailable again.";
+      "Host activity interrupted while dialog was showing. Try calling updateIfNewReleaseAvailable() again.";
 
   static final String APK_INSTALLATION_FAILED =
       "The APK failed to install or installation was canceled by the tester.";

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java

@@ -276,7 +276,7 @@ private UpdateTask updateApp(boolean showDownloadInNotificationManager) {
         LogWrapper.getInstance().v("New release not found.");
         return getErrorUpdateTask(
             new FirebaseAppDistributionException(
-                ErrorMessages.NOT_FOUND_ERROR, UPDATE_NOT_AVAILABLE));
+                ErrorMessages.RELEASE_NOT_FOUND_ERROR, UPDATE_NOT_AVAILABLE));
       }
       if (cachedNewRelease.getDownloadUrl() == null) {
         LogWrapper.getInstance().v("Download failed to execute.");

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionRegistrar.java

@@ -61,7 +61,8 @@ private FirebaseAppDistribution buildFirebaseAppDistribution(ComponentContainer
         container.getProvider(FirebaseInstallationsApi.class);
     SignInStorage signInStorage = new SignInStorage(context);
     FirebaseAppDistributionTesterApiClient testerApiClient =
-        new FirebaseAppDistributionTesterApiClient(firebaseApp, firebaseInstallationsApiProvider);
+        new FirebaseAppDistributionTesterApiClient(
+            firebaseApp, firebaseInstallationsApiProvider, new TesterApiHttpClient(firebaseApp));
     FirebaseAppDistributionLifecycleNotifier lifecycleNotifier =
         FirebaseAppDistributionLifecycleNotifier.getInstance();
     ApkHashExtractor apkHashExtractor = new ApkHashExtractor(firebaseApp.getApplicationContext());