Skip to content

Commit a0f5886

Browse files
authored
Revert FIS Integration for FIAM (#1405)
This reverts commit 261ad66. This reverts commit 0fa1043. This actually doesn't revert those two exactly. This change is meant to be reverted easily to move back to FIS one day when FIS isn't blocking launches.
1 parent 7d0a217 commit a0f5886

File tree

19 files changed

+239
-219
lines changed

19 files changed

+239
-219
lines changed

fiamui-app/fiamui-app.gradle

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,8 @@ dependencies {
5858
implementation project(path: ":firebase-inappmessaging")
5959
implementation 'com.google.guava:guava:24.1-jre-android'
6060

61-
implementation('com.google.firebase:firebase-analytics:17.2.3') {
61+
implementation('com.google.firebase:firebase-analytics:17.0.0') {
6262
exclude group: 'com.google.firebase', module: 'firebase-common'
63-
exclude group: 'com.google.firebase', module: 'firebase-components'
64-
exclude group: 'com.google.firebase', module: 'firebase-installations'
65-
exclude group: 'com.google.firebase', module: 'firebase-installations-interop'
66-
}
67-
implementation('com.google.firebase:firebase-iid:20.1.1') {
68-
exclude group: 'com.google.firebase', module: 'firebase-common'
69-
exclude group: 'com.google.firebase', module: 'firebase-components'
70-
exclude group: 'com.google.firebase', module: 'firebase-installations'
71-
exclude group: 'com.google.firebase', module: 'firebase-installations-interop'
7263
}
7364

7465
implementation "com.android.installreferrer:installreferrer:1.0"

firebase-inappmessaging-display/firebase-inappmessaging-display.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ dependencies {
6464
implementation project(':firebase-inappmessaging')
6565
implementation project(':firebase-components')
6666

67+
implementation('com.google.firebase:firebase-iid:20.0.1') {
68+
exclude group: 'com.google.firebase', module: 'firebase-common'
69+
}
70+
6771
implementation('com.google.firebase:firebase-measurement-connector:18.0.0') {
6872
exclude group: 'com.google.firebase', module: 'firebase-common'
6973
}

firebase-inappmessaging-display/src/main/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@
7575
* <li>send usage metrics to the Firebase backend.
7676
* </ul>
7777
*
78-
* <p>To delete the Instance ID and the data associated with it, see
79-
* FirebaseInstallationsApi#delete.
78+
* <p>To delete the Instance ID and the data associated with it, see {@link
79+
* com.google.firebase.iid.FirebaseInstanceId#deleteInstanceId}.
8080
*/
8181
@Keep
8282
@FirebaseAppScope

firebase-inappmessaging/firebase-inappmessaging.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,6 @@ dependencies {
116116
implementation project(':protolite-well-known-types')
117117
implementation project(':transport:transport-api')
118118
implementation project(':firebase-datatransport')
119-
implementation project(':firebase-installations-interop')
120-
runtimeOnly project(':firebase-installations')
121119

122120
//To provide @Generated annotations
123121
compileOnly 'javax.annotation:jsr250-api:1.0'
@@ -130,6 +128,9 @@ dependencies {
130128
implementation 'io.reactivex.rxjava2:rxjava:2.1.14'
131129
implementation 'io.reactivex.rxjava2:rxandroid:2.0.2'
132130
implementation 'com.google.auto.value:auto-value-annotations:1.6.5'
131+
implementation('com.google.firebase:firebase-iid:20.0.1') {
132+
exclude group: 'com.google.firebase', module: 'firebase-common'
133+
}
133134

134135
implementation('com.google.firebase:firebase-measurement-connector:18.0.0') {
135136
exclude group: 'com.google.firebase', module: 'firebase-common'

firebase-inappmessaging/src/androidTest/java/com/google/firebase/inappmessaging/FirebaseInAppMessagingFlowableTest.java

Lines changed: 27 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
import android.os.Bundle;
4545
import android.os.Looper;
4646
import android.util.Log;
47+
import androidx.annotation.NonNull;
4748
import androidx.test.InstrumentationRegistry;
4849
import androidx.test.runner.AndroidJUnit4;
4950
import com.google.android.gms.tasks.Task;
@@ -52,6 +53,8 @@
5253
import com.google.firebase.FirebaseOptions;
5354
import com.google.firebase.analytics.connector.AnalyticsConnector;
5455
import com.google.firebase.events.Subscriber;
56+
import com.google.firebase.iid.FirebaseInstanceId;
57+
import com.google.firebase.iid.InstanceIdResult;
5558
import com.google.firebase.inappmessaging.CommonTypesProto.Event;
5659
import com.google.firebase.inappmessaging.CommonTypesProto.Priority;
5760
import com.google.firebase.inappmessaging.CommonTypesProto.TriggeringCondition;
@@ -69,8 +72,6 @@
6972
import com.google.firebase.inappmessaging.model.BannerMessage;
7073
import com.google.firebase.inappmessaging.model.CampaignMetadata;
7174
import com.google.firebase.inappmessaging.model.InAppMessage;
72-
import com.google.firebase.installations.FirebaseInstallationsApi;
73-
import com.google.firebase.installations.InstallationTokenResult;
7475
import com.google.internal.firebase.inappmessaging.v1.CampaignProto.ThickContent;
7576
import com.google.internal.firebase.inappmessaging.v1.CampaignProto.VanillaCampaignPayload;
7677
import com.google.internal.firebase.inappmessaging.v1.sdkserving.CampaignImpression;
@@ -112,10 +113,8 @@
112113
@RunWith(AndroidJUnit4.class)
113114
public class FirebaseInAppMessagingFlowableTest {
114115

115-
private static final String PROJECT_NUMBER = "gcm-sender-id";
116-
private static final String APP_ID = "app-id";
117-
private static final String INSTANCE_ID = "instance-id";
118-
private static final String INSTANCE_TOKEN = "token";
116+
public static final String PROJECT_NUMBER = "gcm-sender-id";
117+
public static final String APP_ID = "app-id";
119118
private static final long PAST = 1000000;
120119
private static final long NOW = PAST + 100000;
121120
private static final long FUTURE = NOW + 1000000;
@@ -168,7 +167,7 @@ public class FirebaseInAppMessagingFlowableTest {
168167
@Mock
169168
private MetricsLoggerClient.EngagementMetricsLoggerInterface engagementMetricsLoggerInterface;
170169

171-
@Mock private FirebaseInstallationsApi firebaseInstallations;
170+
@Mock private FirebaseInstanceId instanceId;
172171
@Mock private TestDeviceHelper testDeviceHelper;
173172
@Mock private Subscriber firebaseEventSubscriber;
174173
@Mock private AbtIntegrationHelper abtIntegrationHelper;
@@ -224,16 +223,24 @@ public void setUp() {
224223
clearProtoDiskCache(InstrumentationRegistry.getTargetContext());
225224
application =
226225
spy((Application) InstrumentationRegistry.getTargetContext().getApplicationContext());
227-
when(firebaseInstallations.getId()).thenReturn(Tasks.forResult(INSTANCE_ID));
228-
when(firebaseInstallations.getToken(false))
226+
String id = FirebaseInstanceId.getInstance().getId();
227+
when(instanceId.getId()).thenReturn(id);
228+
when(instanceId.getInstanceId())
229229
.thenReturn(
230230
Tasks.forResult(
231-
InstallationTokenResult.builder()
232-
.setToken(INSTANCE_TOKEN)
233-
.setTokenCreationTimestamp(1)
234-
.setTokenExpirationTimestamp(1)
235-
.build()));
236-
231+
new InstanceIdResult() {
232+
@NonNull
233+
@Override
234+
public String getId() {
235+
return id;
236+
}
237+
238+
@NonNull
239+
@Override
240+
public String getToken() {
241+
return "token";
242+
}
243+
}));
237244
when(testDeviceHelper.isAppInstallFresh()).thenReturn(false);
238245
when(testDeviceHelper.isDeviceInTestMode()).thenReturn(false);
239246

@@ -265,7 +272,7 @@ public void setUp() {
265272
.grpcClientModule(new GrpcClientModule(app))
266273
.testApiClientModule(
267274
new TestApiClientModule(
268-
app, firebaseInstallations, testDeviceHelper, universalComponent.clock()));
275+
app, instanceId, testDeviceHelper, universalComponent.clock()));
269276
TestAppComponent appComponent = appComponentBuilder.build();
270277

271278
instance = appComponent.providesFirebaseInAppMessaging();
@@ -705,7 +712,7 @@ public void logImpression_writesExpectedLogToEngagementMetrics()
705712
.setClientTimestampMillis(NOW)
706713
.setClientApp(
707714
ClientAppInfo.newBuilder()
708-
.setFirebaseInstanceId(INSTANCE_ID)
715+
.setFirebaseInstanceId(FirebaseInstanceId.getInstance().getId())
709716
.setGoogleAppId(APP_ID))
710717
.setEventType(EventType.IMPRESSION_EVENT_TYPE)
711718
.build();
@@ -735,7 +742,7 @@ public void logAction_writesExpectedLogToEngagementMetrics()
735742
.setClientTimestampMillis(NOW)
736743
.setClientApp(
737744
ClientAppInfo.newBuilder()
738-
.setFirebaseInstanceId(INSTANCE_ID)
745+
.setFirebaseInstanceId(FirebaseInstanceId.getInstance().getId())
739746
.setGoogleAppId(APP_ID))
740747
.setEventType(EventType.IMPRESSION_EVENT_TYPE)
741748
.build();
@@ -766,7 +773,7 @@ public void logRenderError_writesExpectedLogToEngagementMetrics()
766773
.setClientTimestampMillis(NOW)
767774
.setClientApp(
768775
ClientAppInfo.newBuilder()
769-
.setFirebaseInstanceId(INSTANCE_ID)
776+
.setFirebaseInstanceId(FirebaseInstanceId.getInstance().getId())
770777
.setGoogleAppId(APP_ID))
771778
.setRenderErrorReason(RenderErrorReason.IMAGE_DISPLAY_ERROR)
772779
.build();
@@ -797,7 +804,7 @@ public void logDismiss_writesExpectedLogToEngagementMetrics()
797804
.setClientTimestampMillis(NOW)
798805
.setClientApp(
799806
ClientAppInfo.newBuilder()
800-
.setFirebaseInstanceId(INSTANCE_ID)
807+
.setFirebaseInstanceId(FirebaseInstanceId.getInstance().getId())
801808
.setGoogleAppId(APP_ID))
802809
.setDismissType(DismissType.AUTO)
803810
.build();

firebase-inappmessaging/src/androidTest/java/com/google/firebase/inappmessaging/TestApiClientModule.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import android.app.Application;
1818
import com.google.firebase.FirebaseApp;
1919
import com.google.firebase.events.Subscriber;
20+
import com.google.firebase.iid.FirebaseInstanceId;
2021
import com.google.firebase.inappmessaging.internal.ApiClient;
2122
import com.google.firebase.inappmessaging.internal.DataCollectionHelper;
2223
import com.google.firebase.inappmessaging.internal.GrpcClient;
@@ -25,7 +26,6 @@
2526
import com.google.firebase.inappmessaging.internal.TestDeviceHelper;
2627
import com.google.firebase.inappmessaging.internal.injection.scopes.FirebaseAppScope;
2728
import com.google.firebase.inappmessaging.internal.time.Clock;
28-
import com.google.firebase.installations.FirebaseInstallationsApi;
2929
import dagger.Lazy;
3030
import dagger.Module;
3131
import dagger.Provides;
@@ -36,26 +36,26 @@
3636
public class TestApiClientModule {
3737

3838
private final FirebaseApp firebaseApp;
39-
private final FirebaseInstallationsApi firebaseInstallations;
39+
private final FirebaseInstanceId firebaseInstanceId;
4040
private SharedPreferencesUtils sharedPreferencesUtils;
4141
private TestDeviceHelper testDeviceHelper;
4242
private Clock clock;
4343

4444
public TestApiClientModule(
4545
FirebaseApp firebaseApp,
46-
FirebaseInstallationsApi firebaseInstallations,
46+
FirebaseInstanceId instanceId,
4747
TestDeviceHelper testDeviceHelper,
4848
Clock clock) {
4949
this.firebaseApp = firebaseApp;
50-
this.firebaseInstallations = firebaseInstallations;
50+
this.firebaseInstanceId = instanceId;
5151
this.testDeviceHelper = testDeviceHelper;
5252
this.sharedPreferencesUtils = new SharedPreferencesUtils(firebaseApp);
5353
this.clock = clock;
5454
}
5555

5656
@Provides
57-
FirebaseInstallationsApi providesFirebaseInstallations() {
58-
return firebaseInstallations;
57+
FirebaseInstanceId providesFirebaseInstanceId() {
58+
return firebaseInstanceId;
5959
}
6060

6161
@Provides
@@ -66,7 +66,8 @@ public FirebaseApp providesfirebaseApp() {
6666

6767
@Provides
6868
DataCollectionHelper providesDataCollectionHelper(Subscriber firebaseEventSubscriber) {
69-
return new DataCollectionHelper(firebaseApp, sharedPreferencesUtils, firebaseEventSubscriber);
69+
return new DataCollectionHelper(
70+
firebaseApp, sharedPreferencesUtils, firebaseInstanceId, firebaseEventSubscriber);
7071
}
7172

7273
@Provides
@@ -85,7 +86,7 @@ ApiClient providesApiClient(
8586
grpcClient,
8687
firebaseApp,
8788
application,
88-
firebaseInstallations,
89+
firebaseInstanceId,
8990
dataCollectionHelper,
9091
clock,
9192
providerInstaller);

firebase-inappmessaging/src/androidTest/java/com/google/firebase/inappmessaging/TestEngagementMetricsLoggerClientModule.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616

1717
import com.google.firebase.FirebaseApp;
1818
import com.google.firebase.analytics.connector.AnalyticsConnector;
19+
import com.google.firebase.iid.FirebaseInstanceId;
1920
import com.google.firebase.inappmessaging.internal.DeveloperListenerManager;
2021
import com.google.firebase.inappmessaging.internal.MetricsLoggerClient;
2122
import com.google.firebase.inappmessaging.internal.MetricsLoggerClient.EngagementMetricsLoggerInterface;
2223
import com.google.firebase.inappmessaging.internal.injection.scopes.FirebaseAppScope;
2324
import com.google.firebase.inappmessaging.internal.time.Clock;
24-
import com.google.firebase.installations.FirebaseInstallationsApi;
2525
import dagger.Module;
2626
import dagger.Provides;
2727

@@ -39,15 +39,15 @@ public TestEngagementMetricsLoggerClientModule(
3939
@Provides
4040
@FirebaseAppScope
4141
public MetricsLoggerClient providesMetricLoggerClient(
42-
FirebaseInstallationsApi firebaseInstallations,
42+
FirebaseInstanceId firebaseInstanceId,
4343
AnalyticsConnector analyticsConnector,
4444
Clock clock,
4545
DeveloperListenerManager developerListenerManager) {
4646
return new MetricsLoggerClient(
4747
engagementMetricsLoggerInterface,
4848
analyticsConnector,
4949
firebaseApp,
50-
firebaseInstallations,
50+
firebaseInstanceId,
5151
clock,
5252
developerListenerManager);
5353
}

firebase-inappmessaging/src/main/java/com/google/firebase/inappmessaging/FirebaseInAppMessaging.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import com.google.android.gms.common.annotation.KeepForSdk;
2020
import com.google.android.gms.common.util.VisibleForTesting;
2121
import com.google.firebase.FirebaseApp;
22+
import com.google.firebase.iid.FirebaseInstanceId;
2223
import com.google.firebase.inappmessaging.internal.DataCollectionHelper;
2324
import com.google.firebase.inappmessaging.internal.DeveloperListenerManager;
2425
import com.google.firebase.inappmessaging.internal.DisplayCallbacksFactory;
@@ -28,7 +29,6 @@
2829
import com.google.firebase.inappmessaging.internal.injection.qualifiers.ProgrammaticTrigger;
2930
import com.google.firebase.inappmessaging.internal.injection.scopes.FirebaseAppScope;
3031
import com.google.firebase.inappmessaging.model.TriggeredInAppMessage;
31-
import com.google.firebase.installations.FirebaseInstallationsApi;
3232
import io.reactivex.disposables.Disposable;
3333
import java.util.concurrent.Executor;
3434
import javax.inject.Inject;
@@ -47,7 +47,7 @@
4747
* </ul>
4848
*
4949
* <p>To delete the Instance ID and the data associated with it, see {@link
50-
* FirebaseInstallationsApi.#delete}.
50+
* com.google.firebase.iid.FirebaseInstanceId#deleteInstanceId}.
5151
*/
5252
@FirebaseAppScope
5353
public class FirebaseInAppMessaging {
@@ -56,7 +56,6 @@ public class FirebaseInAppMessaging {
5656
private final DataCollectionHelper dataCollectionHelper;
5757
private final DisplayCallbacksFactory displayCallbacksFactory;
5858
private final DeveloperListenerManager developerListenerManager;
59-
private final FirebaseInstallationsApi firebaseInstallations;
6059
private final ProgramaticContextualTriggers programaticContextualTriggers;
6160

6261
private boolean areMessagesSuppressed;
@@ -68,21 +67,18 @@ public class FirebaseInAppMessaging {
6867
InAppMessageStreamManager inAppMessageStreamManager,
6968
@ProgrammaticTrigger ProgramaticContextualTriggers programaticContextualTriggers,
7069
DataCollectionHelper dataCollectionHelper,
71-
FirebaseInstallationsApi firebaseInstallations,
7270
DisplayCallbacksFactory displayCallbacksFactory,
7371
DeveloperListenerManager developerListenerManager) {
7472
this.inAppMessageStreamManager = inAppMessageStreamManager;
75-
this.firebaseInstallations = firebaseInstallations;
7673
this.programaticContextualTriggers = programaticContextualTriggers;
7774
this.dataCollectionHelper = dataCollectionHelper;
7875
this.areMessagesSuppressed = false;
7976
this.displayCallbacksFactory = displayCallbacksFactory;
8077
this.developerListenerManager = developerListenerManager;
8178

82-
firebaseInstallations
83-
.getId()
84-
.addOnSuccessListener(
85-
id -> Logging.logi("Starting InAppMessaging runtime with Installation ID " + id));
79+
Logging.logi(
80+
"Starting InAppMessaging runtime with Instance ID "
81+
+ FirebaseInstanceId.getInstance().getId());
8682

8783
Disposable unused =
8884
inAppMessageStreamManager
@@ -118,8 +114,9 @@ public boolean isAutomaticDataCollectionEnabled() {
118114
*
119115
* <p>When enabled, generates a registration token on app startup if there is no valid one and
120116
* generates a new token when it is deleted (which prevents {@link
121-
* FirebaseInstallationsApi.#delete} from stopping the periodic sending of data). This setting is
122-
* persisted across app restarts and overrides the setting specified in your manifest.
117+
* com.google.firebase.iid.FirebaseInstanceId#deleteInstanceId} from stopping the periodic sending
118+
* of data). This setting is persisted across app restarts and overrides the setting specified in
119+
* your manifest.
123120
*
124121
* <p>By default, auto-initialization is enabled. If you need to change the default, (for example,
125122
* because you want to prompt the user before generates/refreshes a registration token on app

firebase-inappmessaging/src/main/java/com/google/firebase/inappmessaging/FirebaseInAppMessagingRegistrar.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.google.firebase.components.ComponentRegistrar;
2828
import com.google.firebase.components.Dependency;
2929
import com.google.firebase.events.Subscriber;
30+
import com.google.firebase.iid.FirebaseInstanceId;
3031
import com.google.firebase.inappmessaging.internal.AbtIntegrationHelper;
3132
import com.google.firebase.inappmessaging.internal.ProgramaticContextualTriggers;
3233
import com.google.firebase.inappmessaging.internal.injection.components.AppComponent;
@@ -39,7 +40,6 @@
3940
import com.google.firebase.inappmessaging.internal.injection.modules.ApplicationModule;
4041
import com.google.firebase.inappmessaging.internal.injection.modules.GrpcClientModule;
4142
import com.google.firebase.inappmessaging.internal.injection.modules.ProgrammaticContextualTriggerFlowableModule;
42-
import com.google.firebase.installations.FirebaseInstallationsApi;
4343
import com.google.firebase.platforminfo.LibraryVersionComponent;
4444
import java.util.Arrays;
4545
import java.util.List;
@@ -57,7 +57,7 @@ public List<Component<?>> getComponents() {
5757
return Arrays.asList(
5858
Component.builder(FirebaseInAppMessaging.class)
5959
.add(Dependency.required(Context.class))
60-
.add(Dependency.required(FirebaseInstallationsApi.class))
60+
.add(Dependency.required(FirebaseInstanceId.class))
6161
.add(Dependency.required(FirebaseApp.class))
6262
.add(Dependency.required(AbtComponent.class))
6363
.add(Dependency.optional(AnalyticsConnector.class))
@@ -71,7 +71,7 @@ public List<Component<?>> getComponents() {
7171

7272
private FirebaseInAppMessaging providesFirebaseInAppMessaging(ComponentContainer container) {
7373
FirebaseApp firebaseApp = container.get(FirebaseApp.class);
74-
FirebaseInstallationsApi firebaseInstallations = container.get(FirebaseInstallationsApi.class);
74+
FirebaseInstanceId firebaseInstanceId = container.get(FirebaseInstanceId.class);
7575
AnalyticsConnector analyticsConnector = container.get(AnalyticsConnector.class);
7676
Subscriber firebaseEventsSubscriber = container.get(Subscriber.class);
7777

@@ -96,7 +96,7 @@ private FirebaseInAppMessaging providesFirebaseInAppMessaging(ComponentContainer
9696
.get(AbtComponent.class)
9797
.get(FirebaseABTesting.OriginService.INAPP_MESSAGING)))
9898
.apiClientModule(
99-
new ApiClientModule(firebaseApp, firebaseInstallations, universalComponent.clock()))
99+
new ApiClientModule(firebaseApp, firebaseInstanceId, universalComponent.clock()))
100100
.grpcClientModule(new GrpcClientModule(firebaseApp))
101101
.universalComponent(universalComponent)
102102
.transportFactory(container.get(TransportFactory.class))

0 commit comments

Comments
 (0)