Rename document_name to document_key (#3383)

Author: schmidt-sebastian

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteIndexManager.java

@@ -322,7 +322,7 @@ private SortedSet<IndexEntry> computeIndexEntries(Document document, FieldIndex
 
   private void addIndexEntry(Document document, IndexEntry indexEntry) {
     db.execute(
-        "INSERT INTO index_entries (index_id, uid, array_value, directional_value, document_name) "
+        "INSERT INTO index_entries (index_id, uid, array_value, directional_value, document_key) "
             + "VALUES(?, ?, ?, ?, ?)",
         indexEntry.getIndexId(),
         uid,
@@ -334,7 +334,7 @@ private void addIndexEntry(Document document, IndexEntry indexEntry) {
   private void deleteIndexEntry(Document document, IndexEntry indexEntry) {
     db.execute(
         "DELETE FROM index_entries WHERE index_id = ? AND uid = ? AND array_value = ? "
-            + "AND directional_value = ? AND document_name = ?",
+            + "AND directional_value = ? AND document_key = ?",
         indexEntry.getIndexId(),
         uid,
         indexEntry.getArrayValue(),
@@ -347,7 +347,7 @@ private SortedSet<IndexEntry> getExistingIndexEntries(
     SortedSet<IndexEntry> results = new TreeSet<>();
     db.query(
             "SELECT array_value, directional_value FROM index_entries "
-                + "WHERE index_id = ? AND document_name = ? AND uid = ?")
+                + "WHERE index_id = ? AND document_key = ? AND uid = ?")
         .binding(fieldIndex.getIndexId(), documentKey.toString(), uid)
         .forEach(
             row ->
@@ -424,7 +424,7 @@ private SQLitePersistence.Query generateQuery(
     // Build the statement. We always include the lower bound, and optionally include an array value
     // and an upper bound.
     StringBuilder statement = new StringBuilder();
-    statement.append("SELECT document_name, directional_value FROM index_entries ");
+    statement.append("SELECT document_key, directional_value FROM index_entries ");
     statement.append("WHERE index_id = ? AND uid = ? ");
     if (arrayValues != null) {
       statement.append("AND array_value = ? ");
@@ -439,14 +439,14 @@ private SQLitePersistence.Query generateQuery(
     // Create the UNION statement by repeating the above generated statement. We can then add
     // ordering and a limit clause.
     StringBuilder sql = repeatSequence(statement, statementCount, " UNION ");
-    sql.append(" ORDER BY directional_value, document_name ");
+    sql.append(" ORDER BY directional_value, document_key ");
     if (target.getLimit() != -1) {
       sql.append("LIMIT ").append(target.getLimit()).append(" ");
     }
 
     if (notIn != null) {
       // Wrap the statement in a NOT-IN call.
-      sql = new StringBuilder("SELECT document_name, directional_value FROM (").append(sql);
+      sql = new StringBuilder("SELECT document_key, directional_value FROM (").append(sql);
       sql.append(") WHERE directional_value NOT IN (");
       sql.append(repeatSequence("?", notIn.length, ", "));
       sql.append(")");

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteSchema.java

@@ -400,8 +400,8 @@ private void createFieldIndex() {
                   + "uid TEXT, "
                   + "array_value BLOB, " // index values for ArrayContains/ArrayContainsAny
                   + "directional_value BLOB, " // index values for equality and inequalities
-                  + "document_name TEXT, "
-                  + "PRIMARY KEY (index_id, uid, array_value, directional_value, document_name))");
+                  + "document_key TEXT, "
+                  + "PRIMARY KEY (index_id, uid, array_value, directional_value, document_key))");
 
           db.execSQL(
               "CREATE INDEX read_time ON remote_documents(read_time_seconds, read_time_nanos)");