Rename collectAndSendFeedback to startFeedback (#3932)

Author: lfkellogg

firebase-appdistribution-api/api.txt

@@ -15,11 +15,11 @@ package com.google.firebase.appdistribution {
 
   public interface FirebaseAppDistribution {
     method @NonNull public com.google.android.gms.tasks.Task<com.google.firebase.appdistribution.AppDistributionRelease> checkForNewRelease();
-    method public void collectAndSendFeedback();
     method @NonNull public static com.google.firebase.appdistribution.FirebaseAppDistribution getInstance();
     method public boolean isTesterSignedIn();
     method @NonNull public com.google.android.gms.tasks.Task<java.lang.Void> signInTester();
     method public void signOutTester();
+    method public void startFeedback();
     method @NonNull public com.google.firebase.appdistribution.UpdateTask updateApp();
     method @NonNull public com.google.firebase.appdistribution.UpdateTask updateIfNewReleaseAvailable();
   }

firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java

@@ -117,11 +117,10 @@ public interface FirebaseAppDistribution {
    * <ol>
    *   <li>Takes a screenshot of the current activity
    *   <li>If tester is not signed in, presents the tester with a Google Sign-in UI
-   *   <li>Looks up the currently installed App Distribution release
    *   <li>Starts a full screen activity for the tester to compose and submit the feedback
    * </ol>
    */
-  void collectAndSendFeedback();
+  void startFeedback();
 
   /** Gets the singleton {@link FirebaseAppDistribution} instance. */
   @NonNull

firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/internal/FirebaseAppDistributionProxy.java

@@ -73,7 +73,7 @@ public UpdateTask updateApp() {
   }
 
   @Override
-  public void collectAndSendFeedback() {
-    delegate.collectAndSendFeedback();
+  public void startFeedback() {
+    delegate.startFeedback();
   }
 }

firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/internal/FirebaseAppDistributionStub.java

@@ -74,7 +74,7 @@ public UpdateTask updateApp() {
   }
 
   @Override
-  public void collectAndSendFeedback() {
+  public void startFeedback() {
     return;
   }
 

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java

@@ -306,12 +306,12 @@ private UpdateTask updateApp(boolean showDownloadInNotificationManager) {
   }
 
   @Override
-  public void collectAndSendFeedback() {
-    collectAndSendFeedback(Executors.newSingleThreadExecutor());
+  public void startFeedback() {
+    startFeedback(Executors.newSingleThreadExecutor());
   }
 
   @VisibleForTesting
-  public void collectAndSendFeedback(Executor taskExecutor) {
+  public void startFeedback(Executor taskExecutor) {
     screenshotTaker
         .takeScreenshot()
         .onSuccessTask(

firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionServiceImplTest.java

@@ -631,11 +631,11 @@ public void updateApp_withApkReleaseAvailable_returnsSameApkTask() {
   }
 
   @Test
-  public void collectAndSendFeedback_signsInTesterAndStartsActivity() throws InterruptedException {
+  public void startFeedback_signsInTesterAndStartsActivity() throws InterruptedException {
     ExecutorService testExecutor = Executors.newSingleThreadExecutor();
     when(mockReleaseIdentifier.identifyRelease()).thenReturn(Tasks.forResult("release-name"));
 
-    firebaseAppDistribution.collectAndSendFeedback(testExecutor);
+    firebaseAppDistribution.startFeedback(testExecutor);
     TestUtils.awaitAsyncOperations(testExecutor);
 
     ArgumentCaptor<Intent> argument = ArgumentCaptor.forClass(Intent.class);

firebase-appdistribution/test-app/src/main/java/com/googletest/firebase/appdistribution/testapp/MainActivity.kt

@@ -12,7 +12,6 @@ import androidx.appcompat.app.AppCompatActivity
 import androidx.appcompat.widget.AppCompatButton
 import com.google.android.gms.tasks.Task
 import com.google.firebase.appdistribution.AppDistributionRelease
-import com.google.firebase.appdistribution.FirebaseAppDistributionException
 import com.google.firebase.appdistribution.UpdateProgress
 import com.google.firebase.appdistribution.ktx.appDistribution
 import com.google.firebase.ktx.Firebase
@@ -170,7 +169,7 @@ class MainActivity : AppCompatActivity() {
         }
 
         feedbackButton.setOnClickListener {
-            firebaseAppDistribution.collectAndSendFeedback()
+            firebaseAppDistribution.startFeedback()
         }
     }