Add the parsed filter to the query.

ehsannas · ehsannas · commit a780ffda9400 · 2021-11-29T11:21:21.000-06:00
diff --git a/firebase-firestore/src/main/java/com/google/firebase/firestore/core/CompositeFilter.java b/firebase-firestore/src/main/java/com/google/firebase/firestore/core/CompositeFilter.java
@@ -89,8 +89,8 @@ public CompositeFilter parseValue(Query query, FirebaseFirestore firestore) {
 
   @Override
   public Query apply(Query query, FirebaseFirestore firestore) {
-    parseValue(query, firestore);
-    return query.filter(this);
+    CompositeFilter parsedFilter = parseValue(query, firestore);
+    return query.filter(parsedFilter);
   }
 
   @Override
diff --git a/firebase-firestore/src/main/java/com/google/firebase/firestore/core/FieldFilter.java b/firebase-firestore/src/main/java/com/google/firebase/firestore/core/FieldFilter.java
@@ -240,8 +240,8 @@ public FieldFilter parseValue(Query query, FirebaseFirestore firestore) {
   /** Applies this filter to the given query */
   @Override
   public Query apply(Query query, FirebaseFirestore firestore) {
-    parseValue(query, firestore);
-    return query.filter(this);
+    FieldFilter parsedFilter = parseValue(query, firestore);
+    return query.filter(parsedFilter);
   }
 
   @Override

Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,8 @@ public CompositeFilter parseValue(Query query, FirebaseFirestore firestore) {`
`89`	`89`
`90`	`90`	`@Override`
`91`	`91`	`public Query apply(Query query, FirebaseFirestore firestore) {`
`92`		`- parseValue(query, firestore);`
`93`		`- return query.filter(this);`
	`92`	`+ CompositeFilter parsedFilter = parseValue(query, firestore);`
	`93`	`+ return query.filter(parsedFilter);`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`@Override`