Skip to content

Commit aa78737

Browse files
committed
actually fix perf
1 parent 5a9d68e commit aa78737

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

firebase-perf/firebase-perf.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ android {
9292

9393
dependencies {
9494
// Firebase Deps
95+
implementation project(':firebase-annotations')
9596
implementation project(':firebase-common')
9697
implementation project(':firebase-components')
9798
implementation project(':firebase-config')

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerfRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
package com.google.firebase.perf;
1616

1717
import androidx.annotation.Keep;
18-
import androidx.annotation.UiThread;
1918
import com.google.android.datatransport.TransportFactory;
2019
import com.google.firebase.FirebaseApp;
2120
import com.google.firebase.StartupTime;
21+
import com.google.firebase.annotations.concurrent.UiThread;
2222
import com.google.firebase.components.Component;
2323
import com.google.firebase.components.ComponentContainer;
2424
import com.google.firebase.components.ComponentRegistrar;

firebase-perf/src/test/java/com/google/firebase/perf/FirebasePerfRegistrarTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,14 @@
1919
import com.google.android.datatransport.TransportFactory;
2020
import com.google.firebase.FirebaseApp;
2121
import com.google.firebase.StartupTime;
22+
import com.google.firebase.annotations.concurrent.UiThread;
2223
import com.google.firebase.components.Component;
2324
import com.google.firebase.components.Dependency;
25+
import com.google.firebase.components.Qualified;
2426
import com.google.firebase.installations.FirebaseInstallationsApi;
2527
import com.google.firebase.remoteconfig.RemoteConfigComponent;
2628
import java.util.List;
29+
import java.util.concurrent.Executor;
2730
import org.junit.Test;
2831
import org.junit.runner.RunWith;
2932
import org.robolectric.RobolectricTestRunner;
@@ -54,7 +57,9 @@ public void testGetComponents() {
5457

5558
assertThat(firebasePerfEarlyComponent.getDependencies())
5659
.containsExactly(
57-
Dependency.required(FirebaseApp.class), Dependency.optionalProvider(StartupTime.class));
60+
Dependency.required(Qualified.qualified(UiThread.class, Executor.class)),
61+
Dependency.required(FirebaseApp.class),
62+
Dependency.optionalProvider(StartupTime.class));
5863

5964
assertThat(firebasePerfEarlyComponent.isLazy()).isFalse();
6065
}

0 commit comments

Comments
 (0)