Skip to content

Commit abf5e74

Browse files
committed
Merge branch 'master' of github.com:firebase/firebase-android-sdk into fisExceptionFix
2 parents 510c613 + 9a8cd2c commit abf5e74

File tree

51 files changed

+1015
-1414
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+1015
-1414
lines changed

firebase-abt/firebase-abt.gradle

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,44 +14,18 @@
1414

1515
plugins {
1616
id 'firebase-library'
17-
id 'com.google.protobuf'
1817
}
1918

2019
firebaseLibrary {
2120
testLab.enabled = false
2221
publishSources = true
2322
}
2423

25-
// TODO(issue/568): Remove this once legacy logic is removed from Remote Config.
26-
protobuf {
27-
protoc {
28-
artifact = "com.google.protobuf:protoc:$protocVersion"
29-
}
30-
generateProtoTasks {
31-
all().each { task ->
32-
task.builtins {
33-
java { option 'lite' }
34-
}
35-
}
36-
}
37-
}
38-
3924
android {
4025

4126
lintOptions {
4227
abortOnError false
4328
}
44-
sourceSets {
45-
main {
46-
proto {
47-
srcDir 'src/proto'
48-
}
49-
50-
resources {
51-
srcDir 'src/proto/com/google/protos'
52-
}
53-
}
54-
}
5529

5630
compileSdkVersion project.targetSdkVersion
5731
defaultConfig {
@@ -78,13 +52,11 @@ dependencies {
7852
exclude group: "com.google.firebase", module: "firebase-common"
7953
}
8054
implementation 'com.google.android.gms:play-services-basement:17.0.0'
81-
implementation "com.google.protobuf:protobuf-javalite:$javaliteVersion"
8255
testImplementation 'org.mockito:mockito-core:2.25.0'
8356
testImplementation 'com.google.truth:truth:0.44'
8457
testImplementation 'junit:junit:4.13-beta-2'
8558
testImplementation 'androidx.test:runner:1.2.0'
8659
testImplementation "org.robolectric:robolectric:$robolectricVersion"
8760
testImplementation 'io.grpc:grpc-testing:1.12.0'
8861
testImplementation 'androidx.test.espresso:espresso-core:3.2.0'
89-
9062
}

firebase-abt/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
version=19.1.1
1+
version=20.0.0
22
latestReleasedVersion=19.1.0

firebase-config/firebase-config.gradle

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,13 @@
1616

1717
plugins {
1818
id 'firebase-library'
19-
id 'com.google.protobuf'
2019
}
2120

2221
firebaseLibrary {
2322
testLab.enabled = true
2423
publishSources = true
2524
}
2625

27-
protobuf {
28-
// Configure the protoc executable
29-
protoc {
30-
// Download from repositories
31-
artifact = "com.google.protobuf:protoc:$protocVersion"
32-
}
33-
generateProtoTasks {
34-
all().each { task ->
35-
task.builtins {
36-
java { option 'lite' }
37-
}
38-
}
39-
}
40-
}
41-
4226
android {
4327
compileSdkVersion project.targetSdkVersion
4428
defaultConfig {
@@ -50,12 +34,6 @@ android {
5034
}
5135

5236
sourceSets {
53-
main {
54-
proto {
55-
srcDir 'src/proto'
56-
}
57-
}
58-
5937
androidTest.resources.srcDirs += ['src/androidTest/res']
6038
}
6139
compileOptions {
@@ -78,7 +56,6 @@ dependencies {
7856
runtimeOnly project(':firebase-installations')
7957

8058
implementation 'com.google.firebase:firebase-measurement-connector:18.0.0'
81-
implementation "com.google.protobuf:protobuf-javalite:$javaliteVersion"
8259
implementation 'com.google.android.gms:play-services-tasks:17.0.2'
8360

8461
compileOnly 'com.google.code.findbugs:jsr305:3.0.2'

firebase-config/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# limitations under the License.
1515
#
1616

17-
version=19.2.1
17+
version=20.0.0
1818
latestReleasedVersion=19.2.0
1919
android.enableUnitTestBinaryResources=true
2020

firebase-config/src/main/java/com/google/firebase/remoteconfig/RemoteConfigComponent.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import com.google.firebase.remoteconfig.internal.ConfigGetParameterHandler;
3434
import com.google.firebase.remoteconfig.internal.ConfigMetadataClient;
3535
import com.google.firebase.remoteconfig.internal.ConfigStorageClient;
36-
import com.google.firebase.remoteconfig.internal.LegacyConfigsHandler;
3736
import java.util.HashMap;
3837
import java.util.Map;
3938
import java.util.Random;
@@ -99,7 +98,6 @@ public class RemoteConfigComponent {
9998
firebaseInstallations,
10099
firebaseAbt,
101100
analyticsConnector,
102-
new LegacyConfigsHandler(context, firebaseApp.getOptions().getApplicationId()),
103101
/* loadGetDefault= */ true);
104102
}
105103

@@ -112,7 +110,6 @@ protected RemoteConfigComponent(
112110
FirebaseInstallationsApi firebaseInstallations,
113111
FirebaseABTesting firebaseAbt,
114112
@Nullable AnalyticsConnector analyticsConnector,
115-
LegacyConfigsHandler legacyConfigsHandler,
116113
boolean loadGetDefault) {
117114
this.context = context;
118115
this.executorService = executorService;
@@ -129,7 +126,6 @@ protected RemoteConfigComponent(
129126
if (loadGetDefault) {
130127
// Loads the default namespace's configs from disk on App startup.
131128
Tasks.call(executorService, this::getDefault);
132-
Tasks.call(executorService, legacyConfigsHandler::saveLegacyConfigsIfNecessary);
133129
}
134130
}
135131

@@ -206,15 +202,6 @@ public synchronized void setCustomHeaders(Map<String, String> customHeaders) {
206202
}
207203

208204
private ConfigCacheClient getCacheClient(String namespace, String configStoreType) {
209-
return getCacheClient(context, appId, namespace, configStoreType);
210-
}
211-
212-
/**
213-
* The {@link LegacyConfigsHandler} needs access to multiple cache clients, and the simplest way
214-
* to provide it access is to keep this method public and static.
215-
*/
216-
public static ConfigCacheClient getCacheClient(
217-
Context context, String appId, String namespace, String configStoreType) {
218205
String fileName =
219206
String.format(
220207
"%s_%s_%s_%s.json",

0 commit comments

Comments
 (0)