Skip to content

Commit ae742a0

Browse files
committed
Address review comments.
1 parent 668bd6b commit ae742a0

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

firebase-annotations/src/main/java/com/google/firebase/annotations/concurrent/Background.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
/**
2222
* An executor/coroutine dispatcher for long running tasks including disk IO, heavy CPU
2323
* computations.
24+
*
25+
* <p>For operations that can block for long periods of time, like network requests, use the {@link
26+
* Blocking} executor.
2427
*/
2528
@Qualifier
2629
@Target({ElementType.PARAMETER, ElementType.METHOD, ElementType.FIELD})

firebase-annotations/src/main/java/com/google/firebase/annotations/concurrent/Lightweight.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import javax.inject.Qualifier;
2020

2121
/**
22-
* An executor/coroutine dispatcher for lightweight tasks that never block(on IO or other tasks).
22+
* An executor/coroutine dispatcher for lightweight tasks that never block (on IO or other tasks).
2323
*/
2424
@Qualifier
2525
@Target({ElementType.PARAMETER, ElementType.METHOD, ElementType.FIELD})

firebase-common/src/test/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<!-- Copyright 2019 Google LLC -->
2+
<!-- Copyright 2022 Google LLC -->
33
<!-- -->
44
<!-- Licensed under the Apache License, Version 2.0 (the "License"); -->
55
<!-- you may not use this file except in compliance with the License. -->

tools/lint/src/main/kotlin/CheckRegistry.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class CheckRegistry : IssueRegistry() {
2929
NonAndroidxNullabilityDetector.NON_ANDROIDX_NULLABILITY,
3030
DeferredApiDetector.INVALID_DEFERRED_API_USE,
3131
ProviderAssignmentDetector.INVALID_PROVIDER_ASSIGNMENT
32-
// TODO(vkryachko): enable the check after migration.
32+
// TODO(vkryachko): enable the check after suppressing current violations.
3333
// ThreadPoolDetector.THREAD_POOL_CREATION
3434
)
3535

0 commit comments

Comments
 (0)