Skip to content

Commit af1ae3a

Browse files
committed
Address comments.
1 parent b211f3c commit af1ae3a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionInitiator.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ internal class SessionInitiator(
3333
private val initiateSessionStart: () -> Unit
3434
) {
3535
private var backgroundTime = elapsedRealtime()
36-
private val sessionTimeout = SessionsSettings().sessionRestartTimeout
3736

3837
init {
3938
initiateSessionStart()
@@ -45,6 +44,7 @@ internal class SessionInitiator(
4544

4645
fun appForegrounded() {
4746
val interval = elapsedRealtime() - backgroundTime
47+
val sessionTimeout = SessionsSettings().sessionRestartTimeout
4848
if (interval > sessionTimeout) {
4949
initiateSessionStart()
5050
}

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionsSettings.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ import kotlin.time.Duration.Companion.minutes
2626
*/
2727
internal class SessionsSettings {
2828
// Setting to qualify if sessions service is enabled.
29-
internal val sessionsEnabled: Boolean
29+
val sessionsEnabled: Boolean
3030
get() {
3131
return true
3232
}
3333

3434
// Setting that provides the sessions sampling rate.
35-
internal val samplingRate: Double
35+
val samplingRate: Double
3636
get() {
3737
return 1.0
3838
}
@@ -42,8 +42,8 @@ internal class SessionsSettings {
4242
get() = 30.minutes
4343

4444
// Update the settings for all the settings providers
45-
internal fun updateSettings() {
45+
fun updateSettings() {
4646
// Placeholder to initiate settings update on different sources
4747
// Expected sources: RemoteSettings, ManifestOverrides, SDK Defaults
4848
}
49-
}
49+

0 commit comments

Comments
 (0)