Skip to content

Commit b0415e7

Browse files
authored
Merge 6c2aaa4 into 6243355
2 parents 6243355 + 6c2aaa4 commit b0415e7

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandler.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,11 +575,12 @@ public static FetchResponse forBackendUpdatesFetched(
575575
lastFetchETag);
576576
}
577577

578-
public static FetchResponse forBackendHasNoUpdates(Date fetchTime) {
578+
public static FetchResponse forBackendHasNoUpdates(
579+
Date fetchTime, ConfigContainer fetchedConfigs) {
579580
return new FetchResponse(
580581
fetchTime,
581582
Status.BACKEND_HAS_NO_UPDATES,
582-
/*fetchedConfigs=*/ null,
583+
/*fetchedConfigs=*/ fetchedConfigs,
583584
/*lastFetchETag=*/ null);
584585
}
585586

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigFetchHttpClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,12 @@ FetchResponse fetch(
216216
} catch (IOException e) {
217217
}
218218
}
219+
ConfigContainer fetchedConfigs = extractConfigs(fetchResponse, currentTime);
219220

220221
if (!backendHasUpdates(fetchResponse)) {
221-
return FetchResponse.forBackendHasNoUpdates(currentTime);
222+
return FetchResponse.forBackendHasNoUpdates(currentTime, fetchedConfigs);
222223
}
223224

224-
ConfigContainer fetchedConfigs = extractConfigs(fetchResponse, currentTime);
225225
return FetchResponse.forBackendUpdatesFetched(fetchedConfigs, fetchResponseETag);
226226
}
227227

firebase-config/src/test/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandlerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ private void setBackendResponseToNoChange(Date date) throws Exception {
794794
/* customHeaders= */ any(),
795795
/* firstOpenTime= */ any(),
796796
/* currentTime= */ any()))
797-
.thenReturn(FetchResponse.forBackendHasNoUpdates(date));
797+
.thenReturn(FetchResponse.forBackendHasNoUpdates(date, firstFetchedContainer));
798798
}
799799

800800
private void fetchCallToBackendThrowsException(int httpErrorCode) throws Exception {

firebase-config/src/test/java/com/google/firebase/remoteconfig/internal/ConfigFetchHttpClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public void fetch_noChange_responseNotSet() throws Exception {
167167
FetchResponse response = fetch(SECOND_ETAG);
168168

169169
assertThat(response.getLastFetchETag()).isNull();
170-
assertThat(response.getFetchedConfigs()).isNull();
170+
assertThat(response.getFetchedConfigs()).isNotNull();
171171
}
172172

173173
@Test

0 commit comments

Comments
 (0)