Skip to content

Commit b255861

Browse files
committed
use FirebasePerfProvider.getAppStartTime
1 parent 00625bf commit b255861

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.google.android.gms.common.util.VisibleForTesting;
2323
import com.google.firebase.inject.Provider;
2424
import com.google.firebase.perf.logging.AndroidLogger;
25+
import com.google.firebase.perf.provider.FirebasePerfProvider;
2526
import com.google.firebase.perf.util.Optional;
2627
import com.google.firebase.remoteconfig.FirebaseRemoteConfig;
2728
import com.google.firebase.remoteconfig.FirebaseRemoteConfigValue;
@@ -93,7 +94,8 @@ private RemoteConfigManager() {
9394
firebaseRemoteConfig == null
9495
? new ConcurrentHashMap<>()
9596
: new ConcurrentHashMap<>(firebaseRemoteConfig.getAll());
96-
this.appStartTimeInMs = getCurrentSystemTimeMillis();
97+
this.appStartTimeInMs =
98+
TimeUnit.MICROSECONDS.toMillis(FirebasePerfProvider.getAppStartTime().getMicros());
9799
this.appStartConfigFetchDelayInMs = appStartConfigFetchDelayInMs;
98100
}
99101

firebase-perf/src/test/java/com/google/firebase/perf/config/RemoteConfigManagerTest.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.google.android.gms.tasks.TaskCompletionSource;
2828
import com.google.firebase.inject.Provider;
2929
import com.google.firebase.perf.FirebasePerformanceTestBase;
30+
import com.google.firebase.perf.provider.FirebasePerfProvider;
3031
import com.google.firebase.remoteconfig.FirebaseRemoteConfig;
3132
import com.google.firebase.remoteconfig.FirebaseRemoteConfigInfo;
3233
import com.google.firebase.remoteconfig.FirebaseRemoteConfigSettings;
@@ -808,8 +809,10 @@ public void triggerRemoteConfigFetchIfNecessary_doesNotFetchBeforeAppStartRandom
808809
appStartConfigFetchDelay));
809810

810811
// Simulate time fast forward to some time before fetch time is up
812+
long appStartTimeInMs =
813+
TimeUnit.MICROSECONDS.toMillis(FirebasePerfProvider.getAppStartTime().getMicros());
811814
when(remoteConfigManagerPartialMock.getCurrentSystemTimeMillis())
812-
.thenReturn(System.currentTimeMillis() + appStartConfigFetchDelay - 2000);
815+
.thenReturn(appStartTimeInMs + appStartConfigFetchDelay - 2000);
813816

814817
simulateFirebaseRemoteConfigLastFetchStatus(
815818
FirebaseRemoteConfig.LAST_FETCH_STATUS_NO_FETCH_YET);
@@ -833,8 +836,10 @@ public void triggerRemoteConfigFetchIfNecessary_fetchesAfterAppStartRandomDelay(
833836
appStartConfigFetchDelay));
834837

835838
// Simulate time fast forward to 2s after fetch delay time is up
839+
long appStartTimeInMs =
840+
TimeUnit.MICROSECONDS.toMillis(FirebasePerfProvider.getAppStartTime().getMicros());
836841
when(remoteConfigManagerPartialMock.getCurrentSystemTimeMillis())
837-
.thenReturn(System.currentTimeMillis() + appStartConfigFetchDelay + 2000);
842+
.thenReturn(appStartTimeInMs + appStartConfigFetchDelay + 2000);
838843

839844
simulateFirebaseRemoteConfigLastFetchStatus(
840845
FirebaseRemoteConfig.LAST_FETCH_STATUS_NO_FETCH_YET);

0 commit comments

Comments
 (0)