Add failure test case for RemoteSettingsFetcher

Author: mrober

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/settings/RemoteSettingsFetcher.kt

@@ -33,8 +33,10 @@ internal interface CrashlyticsSettingsFetcher {
   )
 }
 
-internal class RemoteSettingsFetcher(private val appInfo: ApplicationInfo) :
-  CrashlyticsSettingsFetcher {
+internal class RemoteSettingsFetcher(
+  private val appInfo: ApplicationInfo,
+  private val baseUrl: String = FIREBASE_SESSIONS_BASE_URL_STRING
+) : CrashlyticsSettingsFetcher {
   override suspend fun doConfigFetch(
     headerOptions: Map<String, String>,
     onSuccess: suspend (JSONObject) -> Unit,
@@ -72,7 +74,7 @@ internal class RemoteSettingsFetcher(private val appInfo: ApplicationInfo) :
     val uri =
       Uri.Builder()
         .scheme("https")
-        .authority(FIREBASE_SESSIONS_BASE_URL_STRING)
+        .authority(baseUrl)
         .appendPath("spi")
         .appendPath("v2")
         .appendPath("platforms")

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/RemoteSettingsTest.kt

@@ -21,22 +21,26 @@ import com.google.common.truth.Truth.assertThat
 import com.google.firebase.FirebaseApp
 import com.google.firebase.concurrent.TestOnlyExecutors
 import com.google.firebase.sessions.settings.RemoteSettings
+import com.google.firebase.sessions.settings.RemoteSettingsFetcher
 import com.google.firebase.sessions.testing.FakeFirebaseApp
 import com.google.firebase.sessions.testing.FakeFirebaseInstallations
 import com.google.firebase.sessions.testing.FakeRemoteConfigFetcher
+import com.google.firebase.sessions.testing.TestSessionEventData.TEST_APPLICATION_INFO
 import kotlin.time.Duration.Companion.minutes
+import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.asCoroutineDispatcher
 import kotlinx.coroutines.test.runTest
 import org.json.JSONObject
 import org.junit.After
 import org.junit.Test
 import org.junit.runner.RunWith
 
+@OptIn(ExperimentalCoroutinesApi::class)
 @RunWith(AndroidJUnit4::class)
 class RemoteSettingsTest {
 
   @Test
-  fun RemoteSettings_successfulFetchCachesValues() = runTest {
+  fun remoteSettings_successfulFetchCachesValues() = runTest {
     val firebaseApp = FakeFirebaseApp().firebaseApp
     val context = firebaseApp.applicationContext
     val firebaseInstallations = FakeFirebaseInstallations("FaKeFiD")
@@ -67,7 +71,7 @@ class RemoteSettingsTest {
   }
 
   @Test
-  fun RemoteSettings_successfulFetchWithLessConfigsCachesOnlyReceivedValues() = runTest {
+  fun remoteSettings_successfulFetchWithLessConfigsCachesOnlyReceivedValues() = runTest {
     val firebaseApp = FakeFirebaseApp().firebaseApp
     val context = firebaseApp.applicationContext
     val firebaseInstallations = FakeFirebaseInstallations("FaKeFiD")
@@ -100,7 +104,7 @@ class RemoteSettingsTest {
   }
 
   @Test
-  fun RemoteSettings_successfulRefetchUpdatesCache() = runTest {
+  fun remoteSettings_successfulReFetchUpdatesCache() = runTest {
     val firebaseApp = FakeFirebaseApp().firebaseApp
     val context = firebaseApp.applicationContext
     val firebaseInstallations = FakeFirebaseInstallations("FaKeFiD")
@@ -146,7 +150,7 @@ class RemoteSettingsTest {
   }
 
   @Test
-  fun RemoteSettings_successfulFetchWithEmptyConfigRetainsOldConfigs() = runTest {
+  fun remoteSettings_successfulFetchWithEmptyConfigRetainsOldConfigs() = runTest {
     val firebaseApp = FakeFirebaseApp().firebaseApp
     val context = firebaseApp.applicationContext
     val firebaseInstallations = FakeFirebaseInstallations("FaKeFiD")
@@ -186,6 +190,20 @@ class RemoteSettingsTest {
     remoteSettings.clearCachedSettings()
   }
 
+  @Test
+  fun remoteSettingsFetcher_badFetch_callsOnFailure() = runTest {
+    var failure: String? = null
+
+    RemoteSettingsFetcher(TEST_APPLICATION_INFO, baseUrl = "this.url.is.invalid")
+      .doConfigFetch(
+        headerOptions = emptyMap(),
+        onSuccess = {},
+        onFailure = { failure = it },
+      )
+
+    assertThat(failure).isNotNull()
+  }
+
   @After
   fun cleanUp() {
     FirebaseApp.clearInstancesForTest()

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/testing/TestSessionEventData.kt

@@ -58,23 +58,25 @@ internal object TestSessionEventData {
       firebaseInstallationId = "",
     )
 
+  val TEST_APPLICATION_INFO =
+    ApplicationInfo(
+      appId = FakeFirebaseApp.MOCK_APP_ID,
+      deviceModel = Build.MODEL,
+      sessionSdkVersion = BuildConfig.VERSION_NAME,
+      osVersion = Build.VERSION.RELEASE,
+      logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD,
+      AndroidApplicationInfo(
+        packageName = ApplicationProvider.getApplicationContext<Context>().packageName,
+        versionName = FakeFirebaseApp.MOCK_APP_VERSION,
+        appBuildVersion = FakeFirebaseApp.MOCK_APP_BUILD_VERSION,
+        deviceManufacturer = Build.MANUFACTURER,
+      ),
+    )
+
   val TEST_SESSION_EVENT =
     SessionEvent(
       eventType = EventType.SESSION_START,
       sessionData = TEST_SESSION_DATA,
-      applicationInfo =
-        ApplicationInfo(
-          appId = FakeFirebaseApp.MOCK_APP_ID,
-          deviceModel = Build.MODEL,
-          sessionSdkVersion = BuildConfig.VERSION_NAME,
-          osVersion = Build.VERSION.RELEASE,
-          logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD,
-          AndroidApplicationInfo(
-            packageName = ApplicationProvider.getApplicationContext<Context>().packageName,
-            versionName = FakeFirebaseApp.MOCK_APP_VERSION,
-            appBuildVersion = FakeFirebaseApp.MOCK_APP_BUILD_VERSION,
-            deviceManufacturer = Build.MANUFACTURER,
-          ),
-        )
+      applicationInfo = TEST_APPLICATION_INFO
     )
 }