Skip to content

Commit b8aa2c8

Browse files
committed
Fill in device_model field for AQS
1 parent c290eca commit b8aa2c8

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionEvents.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.firebase.sessions
1818

19+
import android.os.Build
1920
import com.google.firebase.FirebaseApp
2021
import com.google.firebase.encoders.DataEncoder
2122
import com.google.firebase.encoders.FieldDescriptor
@@ -127,7 +128,7 @@ internal object SessionEvents {
127128

128129
return ApplicationInfo(
129130
appId = firebaseApp.options.applicationId,
130-
deviceModel = "",
131+
deviceModel = Build.MODEL,
131132
sessionSdkVersion = BuildConfig.VERSION_NAME,
132133
logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD,
133134
androidAppInfo =

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/ApplicationInfoTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ApplicationInfoTest {
3636
.isEqualTo(
3737
ApplicationInfo(
3838
appId = FakeFirebaseApp.MOCK_APP_ID,
39-
deviceModel = "",
39+
deviceModel = "robolectric",
4040
sessionSdkVersion = BuildConfig.VERSION_NAME,
4141
logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD,
4242
AndroidApplicationInfo(

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/SessionEventEncoderTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class SessionEventEncoderTest {
6868
},
6969
"application_info":{
7070
"app_id":"1:12345:android:app",
71-
"device_model":"",
71+
"device_model":"robolectric",
7272
"session_sdk_version":"0.1.0",
7373
"log_environment":3,
7474
"android_app_info":{

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/testing/TestSessionEventData.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ internal object TestSessionEventData {
5555
applicationInfo =
5656
ApplicationInfo(
5757
appId = FakeFirebaseApp.MOCK_APP_ID,
58-
deviceModel = "",
58+
deviceModel = "robolectric",
5959
sessionSdkVersion = BuildConfig.VERSION_NAME,
6060
logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD,
6161
AndroidApplicationInfo(

0 commit comments

Comments
 (0)