Skip to content

Commit b9b2978

Browse files
committed
address comments.
1 parent 69e74fa commit b9b2978

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/Query.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ private FieldFilter parseFieldFilter(@NonNull FieldPath fieldPath, Operator op,
430430
return filter;
431431
}
432432

433-
// TODO(ehsann): This method will become public API. Change visibility and add documentation.
433+
// TODO(orquery): This method will become public API. Change visibility and add documentation.
434434
private Query where(Filter filter) {
435435
return new Query(
436436
query.filter(parseFieldFilter(filter.getField(), filter.getOperator(), filter.getValue())),

firebase-firestore/src/main/java/com/google/firebase/firestore/core/Target.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ public boolean hasLimit() {
116116
return endAt;
117117
}
118118

119-
/** Returns the field filters from the given list that target the given field path. */
120-
private List<FieldFilter> getFieldFiltersForPath(List<Filter> filters, FieldPath path) {
119+
/** Returns the field filters that target the given field path. */
120+
private List<FieldFilter> getFieldFiltersForPath(FieldPath path) {
121121
List<FieldFilter> result = new ArrayList<>();
122122
for (Filter filter : filters) {
123123
if ((filter instanceof FieldFilter) && (((FieldFilter) filter).getField()).equals(path)) {
@@ -135,7 +135,7 @@ private List<FieldFilter> getFieldFiltersForPath(List<Filter> filters, FieldPath
135135
@Nullable FieldIndex.Segment segment = fieldIndex.getArraySegment();
136136
if (segment == null) return null;
137137

138-
for (FieldFilter fieldFilter : getFieldFiltersForPath(filters, segment.getFieldPath())) {
138+
for (FieldFilter fieldFilter : getFieldFiltersForPath(segment.getFieldPath())) {
139139
switch (fieldFilter.getOperator()) {
140140
case ARRAY_CONTAINS_ANY:
141141
return fieldFilter.getValue().getArrayValue().getValuesList();
@@ -155,7 +155,7 @@ private List<FieldFilter> getFieldFiltersForPath(List<Filter> filters, FieldPath
155155
List<Value> values = new ArrayList<>();
156156

157157
for (FieldIndex.Segment segment : fieldIndex.getDirectionalSegments()) {
158-
for (FieldFilter fieldFilter : getFieldFiltersForPath(filters, segment.getFieldPath())) {
158+
for (FieldFilter fieldFilter : getFieldFiltersForPath(segment.getFieldPath())) {
159159
switch (fieldFilter.getOperator()) {
160160
case EQUAL:
161161
case IN:
@@ -190,7 +190,7 @@ public Bound getLowerBound(FieldIndex fieldIndex) {
190190
boolean segmentInclusive = true;
191191

192192
// Process all filters to find a value for the current field segment
193-
for (FieldFilter fieldFilter : getFieldFiltersForPath(filters, segment.getFieldPath())) {
193+
for (FieldFilter fieldFilter : getFieldFiltersForPath(segment.getFieldPath())) {
194194
Value filterValue = null;
195195
boolean filterInclusive = true;
196196

@@ -272,7 +272,7 @@ public Bound getLowerBound(FieldIndex fieldIndex) {
272272
boolean segmentInclusive = true;
273273

274274
// Process all filters to find a value for the current field segment
275-
for (FieldFilter fieldFilter : getFieldFiltersForPath(filters, segment.getFieldPath())) {
275+
for (FieldFilter fieldFilter : getFieldFiltersForPath(segment.getFieldPath())) {
276276
Value filterValue = null;
277277
boolean filterInclusive = true;
278278

0 commit comments

Comments
 (0)