Cleanup

Author: schmidt-sebastian

firebase-firestore/src/main/java/com/google/firebase/firestore/local/IndexManager.java

@@ -82,9 +82,6 @@ public interface IndexManager {
   @Nullable
   String getNextCollectionGroupToUpdate(Timestamp lastUpdateTime);
 
-  /**
-   * Updates the index entries for the provided documents and corresponding field indexes. Updates
-   * the field indexes in persistence with the latest read time that was processed.
-   */
+  /** Updates the index entries for the provided documents and corresponding field indexes. */
   void updateIndexEntries(Collection<Document> documents);
 }

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteIndexManager.java

@@ -329,33 +329,36 @@ private FieldIndex getPostUpdateIndex(FieldIndex baseIndex, SnapshotVersion newR
 
   /** Creates a list of index entries for the given document. */
   private List<IndexEntry> computeEntries(Document document, FieldIndex fieldIndex) {
-    List<IndexEntry> indexEntries = new ArrayList<>();
 
     @Nullable byte[] directionalValue = encodeDirectionalElements(fieldIndex, document);
-    if (directionalValue != null) {
-      @Nullable FieldIndex.Segment arraySegment = fieldIndex.getArraySegment();
-      if (arraySegment != null) {
-        Value value = document.getField(arraySegment.getFieldPath());
-        if (isArray(value)) {
-          for (Value arrayValue : value.getArrayValue().getValuesList()) {
-            indexEntries.add(
-                IndexEntry.create(
-                    fieldIndex.getIndexId(),
-                    document.getKey().getName(),
-                    document.hasLocalMutations() ? user.getUid() : null,
-                    directionalValue,
-                    encodeSingleElement(arrayValue)));
-          }
+    if (directionalValue == null) {
+      return Collections.emptyList();
+    }
+
+    List<IndexEntry> indexEntries = new ArrayList<>();
+
+    @Nullable FieldIndex.Segment arraySegment = fieldIndex.getArraySegment();
+    if (arraySegment != null) {
+      Value value = document.getField(arraySegment.getFieldPath());
+      if (isArray(value)) {
+        for (Value arrayValue : value.getArrayValue().getValuesList()) {
+          indexEntries.add(
+              IndexEntry.create(
+                  fieldIndex.getIndexId(),
+                  document.getKey().getName(),
+                  document.hasLocalMutations() ? user.getUid() : null,
+                  directionalValue,
+                  encodeSingleElement(arrayValue)));
         }
-      } else {
-        indexEntries.add(
-            IndexEntry.create(
-                fieldIndex.getIndexId(),
-                document.getKey().getName(),
-                document.hasLocalMutations() ? user.getUid() : null,
-                directionalValue,
-                /* arrayValue= */ null));
       }
+    } else {
+      indexEntries.add(
+          IndexEntry.create(
+              fieldIndex.getIndexId(),
+              document.getKey().getName(),
+              document.hasLocalMutations() ? user.getUid() : null,
+              directionalValue,
+              /* arrayValue= */ null));
     }
 
     return indexEntries;