Skip to content

Commit bc877aa

Browse files
committed
Add test case for empty fields, and rename startSession
1 parent d2bb8a9 commit bc877aa

File tree

4 files changed

+36
-4
lines changed

4 files changed

+36
-4
lines changed

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ class FirebaseSessions internal constructor(firebaseApp: FirebaseApp) {
4040
fun greeting(): String = "Matt says hi!"
4141

4242
private fun initiateSessionStart() {
43-
val sessionState = sessionGenerator.generateNewSession()
44-
val sessionEvent = SessionEvents.sessionStart(sessionState)
43+
val sessionDetails = sessionGenerator.generateNewSession()
44+
val sessionEvent = SessionEvents.startSession(sessionDetails)
4545

4646
Log.i(TAG, "Initiate session start: $sessionEvent")
4747
}

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionEvents.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ internal object SessionEvents {
5454
.build()
5555

5656
/** Construct a Session Start event */
57-
fun sessionStart(sessionDetails: SessionDetails) =
57+
fun startSession(sessionDetails: SessionDetails) =
5858
SessionEvent(
5959
eventType = EventType.SESSION_START,
6060
sessionData =

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/SessionEventEncoderTest.kt

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,38 @@ class SessionEventEncoderTest {
5656
)
5757
}
5858

59+
@Test
60+
fun sessionEvent_emptyValues_encodesToJson() {
61+
val sessionEvent =
62+
SessionEvent(
63+
eventType = EventType.EVENT_TYPE_UNKNOWN,
64+
sessionData =
65+
SessionInfo(
66+
sessionId = "",
67+
firstSessionId = "",
68+
sessionIndex = 0,
69+
),
70+
)
71+
72+
val json = SESSION_EVENT_ENCODER.encode(sessionEvent)
73+
74+
assertThat(json)
75+
.isEqualTo(
76+
"""
77+
{
78+
"event_type":0,
79+
"session_data":{
80+
"session_id":"",
81+
"first_session_id":"",
82+
"session_index":0
83+
}
84+
}
85+
"""
86+
.lines()
87+
.joinToString("") { it.trim() }
88+
)
89+
}
90+
5991
@Test
6092
fun eventType_numberedEnum_encodesToJson() {
6193
val json =

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/SessionEventTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class SessionEventTest {
3030
sessionIndex = 3,
3131
)
3232

33-
val sessionEvent = SessionEvents.sessionStart(sessionDetails)
33+
val sessionEvent = SessionEvents.startSession(sessionDetails)
3434

3535
assertThat(sessionEvent)
3636
.isEqualTo(

0 commit comments

Comments
 (0)