Skip to content

Commit be56847

Browse files
committed
Extract 1000L into a constant.
1 parent 0a5e80b commit be56847

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

appcheck/firebase-appcheck/src/main/java/com/google/firebase/appcheck/internal/DefaultAppCheckToken.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ public final class DefaultAppCheckToken extends AppCheckToken {
4141
@VisibleForTesting static final String ISSUED_AT_KEY = "iat";
4242
@VisibleForTesting static final String EXPIRATION_TIME_KEY = "exp";
4343

44+
private static final long ONE_SECOND_MILLIS = 1000L;
45+
4446
// Raw token value
4547
private final String token;
4648
// Timestamp in MS at which this token was generated
@@ -79,7 +81,7 @@ public static DefaultAppCheckToken constructFromAppCheckTokenResponse(
7981
TokenParser.parseTokenClaims(tokenResponse.getAttestationToken());
8082
long iat = getLongFromClaimsSafely(claimsMap, ISSUED_AT_KEY);
8183
long exp = getLongFromClaimsSafely(claimsMap, EXPIRATION_TIME_KEY);
82-
expiresInMillis = (exp - iat) * 1000L;
84+
expiresInMillis = (exp - iat) * ONE_SECOND_MILLIS;
8385
}
8486

8587
return new DefaultAppCheckToken(tokenResponse.getAttestationToken(), expiresInMillis);
@@ -138,10 +140,10 @@ public static DefaultAppCheckToken constructFromRawToken(@NonNull String token)
138140
Map<String, Object> claimsMap = TokenParser.parseTokenClaims(token);
139141
long iat = getLongFromClaimsSafely(claimsMap, ISSUED_AT_KEY);
140142
long exp = getLongFromClaimsSafely(claimsMap, EXPIRATION_TIME_KEY);
141-
long expiresInMillis = (exp - iat) * 1000L;
143+
long expiresInMillis = (exp - iat) * ONE_SECOND_MILLIS;
142144
// We use iat for receivedAtTimestamp as an approximation since we have to guess for raw JWTs
143145
// that we recovered from storage
144-
return new DefaultAppCheckToken(token, expiresInMillis, iat * 1000L);
146+
return new DefaultAppCheckToken(token, expiresInMillis, iat * ONE_SECOND_MILLIS);
145147
}
146148

147149
private static long getLongFromClaimsSafely(

0 commit comments

Comments
 (0)