Skip to content

Commit bf4d9ee

Browse files
committed
kk
1 parent 49ad756 commit bf4d9ee

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

firebase-inappmessaging/src/androidTest/java/com/google/firebase/inappmessaging/FirebaseInAppMessagingFlowableTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@ public void logImpression_logsToEngagementMetrics() {
816816
}
817817

818818
@Test
819-
@Ignore("Does not work yet")
819+
@Ignore("Broken due to Impression Store changes. Needs fixing.")
820820
public void whenlogImpressionFails_doesNotFilterCampaign()
821821
throws ExecutionException, InterruptedException, TimeoutException, FileNotFoundException {
822822
doThrow(new NullPointerException("e1")).when(application).openFileInput(IMPRESSIONS_STORE_FILE);
@@ -943,7 +943,7 @@ public void whenlogEventLimitIncrementSuccess_writesLimitsToDisk() {
943943
}
944944

945945
@Test
946-
@Ignore("Does not work yet")
946+
@Ignore("Broken due to Impression Store changes. Needs fixing.")
947947
public void onImpressionLog_cachesImpressionsInMemory()
948948
throws ExecutionException, InterruptedException, TimeoutException, FileNotFoundException {
949949
CampaignMetadata otherMetadata =
@@ -999,7 +999,7 @@ public void onCorruptImpressionStore_doesNotFilter()
999999
}
10001000

10011001
@Test
1002-
@Ignore("Does not work yet")
1002+
@Ignore("Broken due to Impression Store changes. Needs fixing.")
10031003
public void onImpressionStoreReadFailure_doesNotFilter()
10041004
throws ExecutionException, InterruptedException, TimeoutException, IOException {
10051005
doThrow(new NullPointerException("e1")).when(application).openFileInput(IMPRESSIONS_STORE_FILE);
@@ -1015,7 +1015,7 @@ public void onImpressionStoreReadFailure_doesNotFilter()
10151015
// We work around this by failing hard on the fake service if we do not find an empty impression
10161016
// list
10171017
@Test
1018-
@Ignore("Does not work yet")
1018+
@Ignore("Broken due to Impression Store changes. Needs fixing.")
10191019
public void whenImpressionStorageClientFails_injectsEmptyImpressionListUpstream()
10201020
throws ExecutionException, InterruptedException, TimeoutException, FileNotFoundException {
10211021
VanillaCampaignPayload otherCampaign =

0 commit comments

Comments
 (0)