Skip to content

Commit c4d7bba

Browse files
authored
Migrate apk size table to metrics database. (#748)
* Migrate apk size table to metrics database.
1 parent c0c4337 commit c4d7bba

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/measurement/apksize/ApkSizeJsonBuilder.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ package com.google.firebase.gradle.plugins.measurement.apksize
1818
/** A helper class that generates the APK size measurement JSON report. */
1919
class ApkSizeJsonBuilder {
2020

21-
private static final String PULL_REQUEST_TABLE = "PullRequests"
21+
private static final String PULL_REQUEST_TABLE = "AndroidPullRequests"
2222
private static final String PULL_REQUEST_COLUMN = "pull_request_id"
23-
private static final String APK_SIZE_TABLE = "ApkSizes"
23+
private static final String APK_SIZE_TABLE = "AndroidApkSizes"
2424
private static final String SDK_COLUMN = "sdk_id"
2525
private static final String APK_SIZE_COLUMN = "apk_size"
2626

buildSrc/src/test/groovy/com/google/firebase/gradle/plugins/measurement/apksize/ApkSizeJsonBuilderTest.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class ApkSizeJsonBuilderTest {
4141
def prColumns = prTable.getJSONArray("column_names")
4242
def prMeasurements = prTable.getJSONArray("replace_measurements")
4343

44-
assertEquals("Bad table name", "PullRequests", prTable.getString("table_name"))
44+
assertEquals("Bad table name", "AndroidPullRequests", prTable.getString("table_name"))
4545
assertEquals("Bad column name", "pull_request_id", prColumns.getString(0))
4646
assertEquals("Bad pull request number", 117, prMeasurements.getJSONArray(0).getInt(0))
4747
assertEquals("Too many columns", 1, prColumns.length())
@@ -59,7 +59,7 @@ public class ApkSizeJsonBuilderTest {
5959
def asColumns = asTable.getJSONArray("column_names")
6060
def asMeasurements = asTable.getJSONArray("replace_measurements")
6161

62-
assertEquals("Bad table name", "ApkSizes", asTable.getString("table_name"))
62+
assertEquals("Bad table name", "AndroidApkSizes", asTable.getString("table_name"))
6363
assertEquals("Bad column name", "pull_request_id", asColumns.getString(0))
6464
assertEquals("Bad column name", "sdk_id", asColumns.getString(1))
6565
assertEquals("Bad column name", "apk_size", asColumns.getString(2))
@@ -84,7 +84,7 @@ public class ApkSizeJsonBuilderTest {
8484
def asMeasurements = asTable.getJSONArray("replace_measurements")
8585

8686
// The table itself.
87-
assertEquals("Bad table name", "ApkSizes", asTable.getString("table_name"))
87+
assertEquals("Bad table name", "AndroidApkSizes", asTable.getString("table_name"))
8888
assertEquals("Bad column name", "pull_request_id", asColumns.getString(0))
8989
assertEquals("Bad column name", "sdk_id", asColumns.getString(1))
9090
assertEquals("Bad column name", "apk_size", asColumns.getString(2))

0 commit comments

Comments
 (0)