Skip to content

Commit ca667ef

Browse files
committed
Address feedback
1 parent 71e7703 commit ca667ef

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/MemoryEagerGcSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
*
2525
* <p>This is the default garbage collector unless specified explicitly otherwise.
2626
*
27-
* <p>To use, create an instance using {@link MemoryEagerGcSettings#newBuilder().build()}, then set
27+
* <p>To use, create an instance using {@code MemoryEagerGcSettings#newBuilder().build()}, then set
2828
* the instance to {@code MemoryCacheSettings.Builder#setGcSettings}, and use the built {@code
2929
* MemoryCacheSettings} instance to configure the Firestore SDK.
3030
*/

firebase-firestore/src/main/java/com/google/firebase/firestore/MemoryLruGcSettings.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
/**
2020
* Configures the SDK to use a Least-Recently-Used garbage collector for memory cache.
2121
*
22-
* <p>To use, create an instance using {@link MemoryLruGcSettings#newBuilder().build()}, then set
22+
* <p>To use, create an instance using {@code MemoryLruGcSettings#newBuilder().build()}, then set
2323
* the instance to {@code MemoryCacheSettings.Builder#setGcSettings}, and use the built {@code
2424
* MemoryCacheSettings} instance to configure the Firestore SDK.
2525
*/
@@ -43,7 +43,8 @@ public MemoryLruGcSettings build() {
4343
* a guarantee that the cache will stay below that size, only that if the cache exceeds the
4444
* given size, cleanup will be attempted.
4545
*
46-
* <p>A default size of 100MB is used if unset. The minimum value to set is 1 MB.
46+
* <p>A default size of 100MB (100 * 1024 * 1024) is used if unset. The minimum value to set is
47+
* 1 MB (1024 * 1024).
4748
*
4849
* @return this {@code Builder} instance.
4950
*/
@@ -70,8 +71,8 @@ public static MemoryLruGcSettings.Builder newBuilder() {
7071
* guarantee that the cache will stay below that size, only that if the cache exceeds the given
7172
* size, cleanup will be attempted.
7273
*
73-
* <p>By default, persistent cache is enabled with a cache size of 100 MB. The minimum value is 1
74-
* MB.
74+
* <p>By default, memory LRU cache is enabled with a cache size of 100MB (100 * 1024 * 1024). The
75+
* minimum value is 1 MB (1024 * 1024).
7576
*/
7677
public long getSizeBytes() {
7778
return sizeBytes;

0 commit comments

Comments
 (0)