Skip to content

Commit ca6f4db

Browse files
committed
Address comments.
1 parent d4085da commit ca6f4db

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerfRegistrar.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public List<Component<?>> getComponents() {
4848
.add(Dependency.requiredProvider(RemoteConfigComponent.class))
4949
.add(Dependency.required(FirebaseInstallationsApi.class))
5050
.add(Dependency.requiredProvider(TransportFactory.class))
51-
.factory(this::providesFirebasePerformance)
51+
.factory(FirebasePerfRegistrar::providesFirebasePerformance)
5252
// Since the SDK is eager(auto starts at app start), we use "lazy" dependency for some
5353
// components that are not required during initialization so as not to force initialize
5454
// them at app startup (refer
@@ -58,7 +58,7 @@ public List<Component<?>> getComponents() {
5858
LibraryVersionComponent.create("fire-perf", BuildConfig.VERSION_NAME));
5959
}
6060

61-
public FirebasePerformance providesFirebasePerformance(ComponentContainer container) {
61+
private static FirebasePerformance providesFirebasePerformance(ComponentContainer container) {
6262
FirebasePerformanceComponent component =
6363
DaggerFirebasePerformanceComponent.builder()
6464
.firebasePerformanceModule(

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerformance.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,10 @@ public static FirebasePerformance getInstance() {
133133
// to false if it's been force disabled or it is set to null if neither.
134134
@Nullable private Boolean mPerformanceCollectionForceEnabledState = null;
135135

136-
FirebaseApp firebaseApp;
137-
Provider<RemoteConfigComponent> firebaseRemoteConfigProvider;
138-
FirebaseInstallationsApi firebaseInstallationsApi;
139-
Provider<TransportFactory> transportFactoryProvider;
136+
private FirebaseApp firebaseApp;
137+
private Provider<RemoteConfigComponent> firebaseRemoteConfigProvider;
138+
private FirebaseInstallationsApi firebaseInstallationsApi;
139+
private Provider<TransportFactory> transportFactoryProvider;
140140

141141
@Inject
142142
FirebasePerformance(

firebase-perf/src/main/java/com/google/firebase/perf/FirebasePerformanceModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
public class FirebasePerformanceModule {
2828
private final FirebaseApp firebaseApp;
2929
private final FirebaseInstallationsApi firebaseInstallations;
30-
private Provider<RemoteConfigComponent> remoteConfigComponentProvider;
31-
private Provider<TransportFactory> transportFactoryProvider;
30+
private final Provider<RemoteConfigComponent> remoteConfigComponentProvider;
31+
private final Provider<TransportFactory> transportFactoryProvider;
3232

3333
public FirebasePerformanceModule(
3434
@NonNull FirebaseApp firebaseApp,

0 commit comments

Comments
 (0)