address comments

Author: themiswang

firebase-crashlytics-ndk/gradle.properties

@@ -1,2 +1,2 @@
-version=19.0.4
+version=19.1.0
 latestReleasedVersion=19.0.3

firebase-crashlytics/gradle.properties

@@ -1,2 +1,2 @@
-version=19.0.4
+version=19.1.0
 latestReleasedVersion=19.0.3

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java

@@ -339,12 +339,12 @@ Task<Void> deleteUnsentReports() {
     return unsentReportsHandled.getTask();
   }
 
-  Void submitAllReports(Task<Settings> settingsDataTask) {
+  void submitAllReports(Task<Settings> settingsDataTask) {
     if (!reportingCoordinator.hasReportsToSend()) {
       // Just notify the user that there are no reports and stop.
       Logger.getLogger().v("No crash reports are available to be sent.");
       unsentReportsAvailable.trySetResult(false);
-      return null;
+      return;
     }
     Logger.getLogger().v("Crash reports are available to be sent.");
 
@@ -393,7 +393,6 @@ public Task<Void> then(@Nullable Settings appSettingsData) throws Exception {
                     });
               }
             });
-    return null;
   }
 
   // region Internal "public" API for data capture

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCore.java

@@ -224,19 +224,11 @@ public boolean onPreExecute(AppData appData, SettingsProvider settingsProvider)
   /** Performs background initialization asynchronously on the common worker. */
   @CanIgnoreReturnValue
   public Task<Void> doBackgroundInitializationAsync(SettingsProvider settingsProvider) {
-    return crashlyticsWorkers.common.submit(
-        () -> {
-          try {
-            doBackgroundInitialization(settingsProvider);
-          } catch (Exception e) {
-            Logger.getLogger().e(e.toString());
-          }
-        });
+    return crashlyticsWorkers.common.submit(() -> doBackgroundInitialization(settingsProvider));
   }
 
   /** Performs background initialization synchronously on the calling thread. */
-  @CanIgnoreReturnValue
-  private Void doBackgroundInitialization(SettingsProvider settingsProvider) throws Exception {
+  private void doBackgroundInitialization(SettingsProvider settingsProvider) {
     CrashlyticsWorkers.checkBackgroundThread();
     // create the marker for this run
     markInitializationStarted();
@@ -259,13 +251,10 @@ private Void doBackgroundInitialization(SettingsProvider settingsProvider) throw
         Logger.getLogger().w("Previous sessions could not be finalized.");
       }
 
-      Task<Settings> settings = settingsProvider.getSettingsAsync();
-      controller.submitAllReports(settings);
-      return null;
+      controller.submitAllReports(settingsProvider.getSettingsAsync());
     } catch (Exception e) {
       Logger.getLogger()
           .e("Crashlytics encountered a problem during asynchronous initialization.", e);
-      throw e;
     } finally {
       // The only thing that compels us to leave the marker and start synchronously next time
       // is not executing all the way through this method. That would indicate that we perhaps