Skip to content

Commit ccb5a88

Browse files
authored
Merge branch 'main' into daymon-migrate-firebaselibext
2 parents 5b63de0 + d96507b commit ccb5a88

File tree

67 files changed

+266
-267
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+266
-267
lines changed

.github/workflows/api-information.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
distribution: temurin
1919
cache: gradle
2020
- name: Set up Python 3.10
21-
uses: actions/setup-python@v4
21+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
2222
with:
2323
python-version: '3.10'
2424
- name: Set up fireci

.github/workflows/copyright-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
runs-on: ubuntu-22.04
1212
steps:
1313
- uses: actions/[email protected]
14-
- uses: actions/setup-python@v2
14+
- uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
1515
with:
1616
python-version: '3.9'
1717
- run: |

.github/workflows/fireci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ jobs:
1616
runs-on: ubuntu-22.04
1717
steps:
1818
- uses: actions/[email protected]
19-
- uses: actions/setup-python@v2
19+
- uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
2020
with:
2121
python-version: '3.8'
2222
- run: |
2323
pip install -e "ci/fireci[test]"
2424
- run: |
2525
pytest ci/fireci
2626
- run: |
27-
mypy --config-file ci/fireci/setup.cfg ci/fireci/
27+
mypy --config-file ci/fireci/setup.cfg ci/fireci/

.github/workflows/fireperf-e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
distribution: temurin
3535
cache: gradle
3636
- name: Set up Python 3.10
37-
uses: actions/setup-python@v4
37+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
3838
with:
3939
python-version: '3.10'
4040
- name: Set up fireci

.github/workflows/health-metrics.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
distribution: temurin
3636
cache: gradle
3737
- name: Set up Python 3.10
38-
uses: actions/setup-python@v4
38+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
3939
with:
4040
python-version: '3.10'
4141
- uses: google-github-actions/auth@v2
@@ -70,7 +70,7 @@ jobs:
7070
distribution: temurin
7171
cache: gradle
7272
- name: Set up Python 3.10
73-
uses: actions/setup-python@v4
73+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
7474
with:
7575
python-version: '3.10'
7676
- uses: google-github-actions/auth@v2
@@ -106,7 +106,7 @@ jobs:
106106
distribution: temurin
107107
cache: gradle
108108
- name: Set up Python 3.10
109-
uses: actions/setup-python@v4
109+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
110110
with:
111111
python-version: '3.10'
112112
- uses: google-github-actions/auth@v2

.github/workflows/make-bom.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
runs-on: ubuntu-latest
99
steps:
1010
- name: Set up Python 3.10
11-
uses: actions/setup-python@v4
11+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
1212
with:
1313
python-version: '3.10'
1414
- uses: actions/[email protected]

.github/workflows/release-note-changes.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
cache: gradle
3434

3535
- name: Set up Python 3.10
36-
uses: actions/setup-python@v4
36+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
3737
if: ${{ steps.changed-files.outputs.any_changed == 'true' }}
3838
with:
3939
python-version: '3.10'

.github/workflows/update-cpp-sdk-on-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
runs-on: ubuntu-latest
5252
steps:
5353
- name: Setup python
54-
uses: actions/setup-python@v2
54+
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
5555
with:
5656
python-version: 3.7
5757

appcheck/firebase-appcheck-debug-testing/firebase-appcheck-debug-testing.gradle

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,21 +60,21 @@ dependencies {
6060
api 'com.google.firebase:firebase-common-ktx:21.0.0'
6161
api 'com.google.firebase:firebase-components:18.0.0'
6262

63-
implementation "androidx.test:core:$androidxTestCoreVersion"
63+
implementation libs.androidx.test.core
6464
implementation 'com.google.android.gms:play-services-base:18.0.1'
6565
implementation 'com.google.android.gms:play-services-tasks:18.0.1'
6666

6767
testImplementation project(':appcheck:firebase-appcheck-playintegrity')
68-
testImplementation "androidx.test:core:$androidxTestCoreVersion"
69-
testImplementation "com.google.truth:truth:$googleTruthVersion"
68+
testImplementation libs.androidx.test.core
69+
testImplementation libs.truth
7070
testImplementation 'junit:junit:4.13-beta-2'
7171
testImplementation 'org.mockito:mockito-core:2.25.0'
72-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
72+
testImplementation libs.robolectric
7373

7474
androidTestImplementation project(':firebase-storage')
7575
androidTestImplementation 'androidx.test:runner:1.2.0'
76-
androidTestImplementation "androidx.test.ext:junit:$androidxTestJUnitVersion"
77-
androidTestImplementation "com.google.truth:truth:$googleTruthVersion"
76+
androidTestImplementation libs.androidx.test.junit
77+
androidTestImplementation libs.truth
7878
androidTestImplementation 'junit:junit:4.13-beta-2'
7979
androidTestImplementation 'org.mockito:mockito-core:2.25.0'
8080
}

appcheck/firebase-appcheck-debug/firebase-appcheck-debug.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ dependencies {
6363
exclude group: 'com.google.firebase', module: 'firebase-common'
6464
exclude group: 'com.google.firebase', module: 'firebase-components'
6565
}
66-
testImplementation "androidx.test:core:$androidxTestCoreVersion"
66+
testImplementation libs.androidx.test.core
6767
testImplementation 'androidx.test:rules:1.2.0'
68-
testImplementation "com.google.truth:truth:$googleTruthVersion"
68+
testImplementation libs.truth
6969
testImplementation 'junit:junit:4.13-beta-2'
7070
testImplementation 'org.mockito:mockito-core:2.25.0'
71-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
71+
testImplementation libs.robolectric
7272
}

appcheck/firebase-appcheck-interop/firebase-appcheck-interop.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ dependencies {
4949
implementation 'com.google.android.gms:play-services-base:18.0.1'
5050
implementation 'com.google.android.gms:play-services-tasks:18.0.1'
5151

52-
testImplementation "androidx.test:core:$androidxTestCoreVersion"
52+
testImplementation libs.androidx.test.core
5353
testImplementation 'androidx.test:rules:1.2.0'
54-
testImplementation "com.google.truth:truth:$googleTruthVersion"
54+
testImplementation libs.truth
5555
testImplementation 'junit:junit:4.12'
5656
testImplementation 'org.mockito:mockito-core:2.25.0'
57-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
57+
testImplementation libs.robolectric
5858
}

appcheck/firebase-appcheck-playintegrity/firebase-appcheck-playintegrity.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ dependencies {
6464
exclude group: 'com.google.firebase', module: 'firebase-common'
6565
exclude group: 'com.google.firebase', module: 'firebase-components'
6666
}
67-
testImplementation "androidx.test:core:$androidxTestCoreVersion"
68-
testImplementation "com.google.truth:truth:$googleTruthVersion"
69-
testImplementation 'junit:junit:4.13.2'
67+
testImplementation libs.androidx.test.core
68+
testImplementation libs.truth
69+
testImplementation libs.junit
7070
testImplementation 'org.mockito:mockito-core:3.4.6'
71-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
71+
testImplementation libs.robolectric
7272
}

appcheck/firebase-appcheck/firebase-appcheck.gradle

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,40 +51,40 @@ android {
5151
dependencies {
5252
javadocClasspath 'com.google.auto.value:auto-value-annotations:1.6.6'
5353

54-
api 'com.google.android.gms:play-services-tasks:18.1.0'
54+
api libs.playservices.tasks
5555
api 'com.google.firebase:firebase-annotations:16.2.0'
5656
api "com.google.firebase:firebase-appcheck-interop:17.1.0"
5757
api("com.google.firebase:firebase-common:21.0.0")
5858
api("com.google.firebase:firebase-common-ktx:21.0.0")
5959
api("com.google.firebase:firebase-components:18.0.0")
6060

6161
implementation 'androidx.annotation:annotation:1.1.0'
62-
implementation 'com.google.android.gms:play-services-base:18.1.0'
63-
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
62+
implementation libs.playservices.base
63+
implementation libs.kotlin.stdlib
6464

6565
testImplementation(project(":integ-testing")){
6666
exclude group: 'com.google.firebase', module: 'firebase-common'
6767
exclude group: 'com.google.firebase', module: 'firebase-components'
6868
}
69-
testImplementation "androidx.test:core:$androidxTestCoreVersion"
69+
testImplementation libs.androidx.test.core
7070
testImplementation 'androidx.test:rules:1.2.0'
71-
testImplementation "com.google.truth:truth:$googleTruthVersion"
71+
testImplementation libs.truth
7272
testImplementation 'junit:junit:4.12'
7373
testImplementation 'junit:junit:4.13-beta-2'
74-
testImplementation 'org.mockito:mockito-core:5.2.0'
74+
testImplementation libs.mockito.core
7575
testImplementation 'org.mockito:mockito-inline:5.2.0'
76-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
76+
testImplementation libs.robolectric
7777

7878
androidTestImplementation project(':appcheck:firebase-appcheck')
7979
androidTestImplementation(project(":integ-testing")){
8080
exclude group: 'com.google.firebase', module: 'firebase-common'
8181
exclude group: 'com.google.firebase', module: 'firebase-components'
8282
}
8383
androidTestImplementation "androidx.annotation:annotation:1.0.0"
84-
androidTestImplementation "androidx.test:core:$androidxTestCoreVersion"
84+
androidTestImplementation libs.androidx.test.core
8585
androidTestImplementation 'androidx.test:runner:1.2.0'
86-
androidTestImplementation "androidx.test.ext:junit:$androidxTestJUnitVersion"
87-
androidTestImplementation "com.google.truth:truth:$googleTruthVersion"
86+
androidTestImplementation libs.androidx.test.junit
87+
androidTestImplementation libs.truth
8888
androidTestImplementation 'junit:junit:4.12'
8989
androidTestImplementation 'org.mockito:mockito-core:2.25.0'
9090
androidTestImplementation 'org.mockito:mockito-inline:2.25.0'

appcheck/firebase-appcheck/ktx/ktx.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,14 @@ dependencies {
6161

6262
implementation("com.google.firebase:firebase-components:18.0.0")
6363

64-
testImplementation "com.google.truth:truth:$googleTruthVersion"
64+
testImplementation libs.truth
6565
testImplementation 'junit:junit:4.12'
6666
testImplementation 'org.mockito:mockito-core:2.25.0'
67-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
67+
testImplementation libs.robolectric
6868

69-
androidTestImplementation "androidx.test:core:$androidxTestCoreVersion"
69+
androidTestImplementation libs.androidx.test.core
7070
androidTestImplementation 'androidx.test:runner:1.2.0'
7171
androidTestImplementation 'com.google.firebase:firebase-appcheck-interop:17.1.0'
72-
androidTestImplementation "com.google.truth:truth:$googleTruthVersion"
72+
androidTestImplementation libs.truth
7373
androidTestImplementation 'junit:junit:4.12'
7474
}

build.gradle

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@
1313
// limitations under the License.
1414

1515
buildscript {
16-
// TODO: remove once all sdks have migrated to version catalog
17-
ext.kotlinVersion = libs.versions.kotlin.get()
18-
ext.coroutinesVersion = libs.versions.coroutines.get()
19-
2016
repositories {
2117
google()
2218
mavenCentral()
@@ -47,15 +43,6 @@ buildscript {
4743
apply from: 'sdkProperties.gradle'
4844
apply from: "gradle/errorProne.gradle"
4945

50-
ext {
51-
// TODO: remove once all sdks have migrated to version catalog
52-
googleTruthVersion = libs.versions.truth.get()
53-
grpcVersion = libs.versions.grpc.get()
54-
robolectricVersion = libs.versions.robolectric.get()
55-
androidxTestCoreVersion = libs.versions.androidx.test.core.get()
56-
androidxTestJUnitVersion = libs.versions.androidx.test.junit.get()
57-
}
58-
5946
apply plugin: com.google.firebase.gradle.plugins.PublishingPlugin
6047

6148
apply plugin: com.google.firebase.gradle.plugins.ci.ContinuousIntegrationPlugin

buildSrc/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ dependencies {
5151
implementation("com.google.auto.value:auto-value-annotations:1.8.1")
5252
annotationProcessor("com.google.auto.value:auto-value:1.6.5")
5353
implementation(kotlin("gradle-plugin", "1.8.22"))
54-
implementation("org.json:json:20210307")
54+
implementation(libs.org.json)
5555

5656
implementation("org.eclipse.aether:aether-api:1.0.0.v20140518")
5757
implementation("org.eclipse.aether:aether-util:1.0.0.v20140518")
@@ -71,8 +71,8 @@ dependencies {
7171
implementation(libs.android.gradlePlugin.builder.test.api)
7272

7373
testImplementation(libs.bundles.kotest)
74-
testImplementation("junit:junit:4.13.2")
75-
testImplementation("com.google.truth:truth:1.4.2")
74+
testImplementation(libs.junit)
75+
testImplementation(libs.truth)
7676
testImplementation("commons-io:commons-io:2.15.1")
7777
}
7878

encoders/firebase-decoders-json/firebase-decoders-json.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ dependencies {
4949
implementation 'androidx.annotation:annotation:1.1.0'
5050

5151
testImplementation 'androidx.test:runner:1.2.0'
52-
testImplementation "androidx.test.ext:junit:$androidxTestJUnitVersion"
53-
testImplementation "com.google.truth:truth:$googleTruthVersion"
52+
testImplementation libs.androidx.test.junit
53+
testImplementation libs.truth
5454
testImplementation 'junit:junit:4.13-rc-1'
5555
testImplementation 'org.mockito:mockito-core:2.25.0'
56-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
56+
testImplementation libs.robolectric
5757
}
5858

5959
tasks.withType(JavaCompile) {

encoders/firebase-encoders-json/firebase-encoders-json.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ dependencies {
5555
implementation 'androidx.annotation:annotation:1.1.0'
5656

5757
testImplementation 'androidx.test:runner:1.3.0'
58-
testImplementation "androidx.test.ext:junit:$androidxTestJUnitVersion"
58+
testImplementation libs.androidx.test.junit
5959
testImplementation "com.google.truth:truth:1.0.1"
6060
testImplementation 'junit:junit:4.13'
6161
testImplementation 'org.mockito:mockito-core:3.3.3'
62-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
62+
testImplementation libs.robolectric
6363
}
6464

6565
tasks.withType(JavaCompile) {

encoders/firebase-encoders-proto/firebase-encoders-proto.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ dependencies {
4848

4949
testImplementation 'com.google.guava:guava:31.0-jre'
5050
testImplementation libs.protobuf.java.util
51-
testImplementation "com.google.truth:truth:$googleTruthVersion"
51+
testImplementation libs.truth
5252
testImplementation 'com.google.truth.extensions:truth-proto-extension:1.0'
5353
testImplementation 'junit:junit:4.13.1'
5454
}

encoders/firebase-encoders-reflective/firebase-encoders-reflective.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ dependencies {
5252
implementation 'androidx.annotation:annotation:1.1.0'
5353

5454
testImplementation 'androidx.test:runner:1.3.0'
55-
testImplementation "androidx.test.ext:junit:$androidxTestJUnitVersion"
55+
testImplementation libs.androidx.test.junit
5656
testImplementation 'com.google.truth:truth:1.0.1'
5757
testImplementation 'junit:junit:4.13'
5858
testImplementation 'org.mockito:mockito-core:3.3.3'
59-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
59+
testImplementation libs.robolectric
6060
}

encoders/firebase-encoders/firebase-encoders.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ java {
3333
dependencies {
3434
implementation 'androidx.annotation:annotation:1.1.0'
3535

36-
testImplementation "com.google.truth:truth:$googleTruthVersion"
36+
testImplementation libs.truth
3737
testImplementation 'junit:junit:4.13'
3838
}
3939

firebase-abt/firebase-abt.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ dependencies {
6161
exclude group: "com.google.firebase", module: "firebase-common"
6262
}
6363

64-
implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22")
64+
implementation(libs.kotlin.stdlib.jdk8)
6565

6666
testImplementation 'androidx.test:runner:1.2.0'
6767
testImplementation 'androidx.test.espresso:espresso-core:3.2.0'
6868
testImplementation 'com.google.truth:truth:0.44'
6969
testImplementation 'io.grpc:grpc-testing:1.12.0'
7070
testImplementation 'junit:junit:4.13-beta-2'
7171
testImplementation 'org.mockito:mockito-core:2.25.0'
72-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
72+
testImplementation libs.robolectric
7373
}

firebase-appdistribution-api/firebase-appdistribution-api.gradle

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,24 +58,23 @@ dependencies {
5858
api("com.google.firebase:firebase-components:18.0.0")
5959

6060
implementation 'androidx.annotation:annotation:1.1.0'
61-
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
61+
implementation libs.kotlin.stdlib
6262

6363
compileOnly 'com.google.auto.value:auto-value-annotations:1.6.5'
6464

6565
annotationProcessor 'com.google.auto.value:auto-value:1.6.5'
6666

6767
testImplementation project(':firebase-appdistribution-api')
68-
testImplementation "androidx.test:core:$androidxTestCoreVersion"
69-
testImplementation "com.google.truth:truth:$googleTruthVersion"
70-
testImplementation 'junit:junit:4.12'
71-
testImplementation 'junit:junit:4.13.2'
68+
testImplementation libs.androidx.test.core
69+
testImplementation libs.truth
70+
testImplementation libs.junit
7271
testImplementation 'org.mockito:mockito-core:2.25.0'
7372
testImplementation 'org.mockito:mockito-inline:3.4.0'
74-
testImplementation "org.robolectric:robolectric:$robolectricVersion"
73+
testImplementation libs.robolectric
7574

76-
androidTestImplementation "androidx.test:core:$androidxTestCoreVersion"
75+
androidTestImplementation libs.androidx.test.core
7776
androidTestImplementation 'androidx.test:runner:1.2.0'
78-
androidTestImplementation "com.google.truth:truth:$googleTruthVersion"
77+
androidTestImplementation libs.truth
7978
androidTestImplementation 'junit:junit:4.12'
8079
androidTestImplementation "org.mockito:mockito-android:3.4.0"
8180
}

0 commit comments

Comments
 (0)