Skip to content

Commit d0eb9f3

Browse files
committed
update
1 parent c44e36a commit d0eb9f3

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

firebase-common/src/main/java/com/google/firebase/platforminfo/GlobalLibraryVersionRegistrar.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import java.util.Collections;
1818
import java.util.HashSet;
1919
import java.util.Set;
20-
import java.util.logging.Logger;
2120

2221
/**
2322
* In order to allow the C++ and Unity SDKs to publish their versions without the use of the
@@ -29,7 +28,6 @@
2928
public class GlobalLibraryVersionRegistrar {
3029
private final Set<LibraryVersion> infos = new HashSet<>();
3130
private static volatile GlobalLibraryVersionRegistrar INSTANCE;
32-
private static final Logger LOGGER = Logger.getLogger(GlobalLibraryVersionRegistrar.class.getName());
3331

3432
GlobalLibraryVersionRegistrar() {}
3533

@@ -41,7 +39,6 @@ public class GlobalLibraryVersionRegistrar {
4139
public void registerVersion(String sdkName, String version) {
4240

4341
synchronized (infos) {
44-
LOGGER.info("Registering version");
4542
infos.add(LibraryVersion.create(sdkName, version));
4643
}
4744
}

firebase-ml-modeldownloader/src/androidTest/java/com/google/firebase/ml/modeldownloader/TestPublicApi.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,14 @@ public void listModels() throws ExecutionException, InterruptedException {
6363
Tasks.await(modelSetTask);
6464
assertEquals(modelSetTask.getResult().size(), 0);
6565

66-
// Task<CustomModel> modelTask =
67-
// FirebaseModelDownloader.getInstance()
68-
// .getModel(
69-
// MODEL_NAME_LOCAL,
70-
// DownloadType.LATEST_MODEL,
71-
// new CustomModelDownloadConditions.Builder().build());
72-
// Tasks.await(modelTask);
73-
// assertTrue(modelTask.isSuccessful());
66+
Task<CustomModel> modelTask =
67+
FirebaseModelDownloader.getInstance()
68+
.getModel(
69+
MODEL_NAME_LOCAL,
70+
DownloadType.LATEST_MODEL,
71+
new CustomModelDownloadConditions.Builder().build());
72+
Tasks.await(modelTask);
73+
assertTrue(modelTask.isSuccessful());
7474

7575
Task<CustomModel> modelTask =
7676
FirebaseModelDownloader.getInstance()
@@ -83,7 +83,7 @@ public void listModels() throws ExecutionException, InterruptedException {
8383

8484
modelSetTask = FirebaseModelDownloader.getInstance().listDownloadedModels();
8585
Tasks.await(modelSetTask);
86-
assertEquals(modelSetTask.getResult().size(), 1);
86+
assertEquals(modelSetTask.getResult().size(), 2);
8787
}
8888

8989
@Test

0 commit comments

Comments
 (0)