Skip to content

Commit d24aa62

Browse files
lfkelloggkaibolay
authored andcommitted
Focus some synchronized blocks in lifecycle notifier (#4526)
1 parent 9d679c2 commit d24aa62

File tree

1 file changed

+18
-13
lines changed

1 file changed

+18
-13
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionLifecycleNotifier.java

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -235,22 +235,27 @@ <A extends Activity> Task<Activity> getForegroundActivity(@Nullable Class<A> cla
235235
return Tasks.forResult(
236236
getActivityWithIgnoredClass(currentActivity, previousActivity, classToIgnore));
237237
}
238+
}
238239

239-
TaskCompletionSource<Activity> task = new TaskCompletionSource<>();
240+
TaskCompletionSource<Activity> task = new TaskCompletionSource<>();
240241

241-
addOnActivityResumedListener(
242-
new OnActivityResumedListener() {
243-
@Override
244-
public void onResumed(Activity activity) {
245-
synchronized (lock) {
246-
task.setResult(
247-
getActivityWithIgnoredClass(activity, previousActivity, classToIgnore));
248-
}
249-
removeOnActivityResumedListener(this);
250-
}
251-
});
242+
addOnActivityResumedListener(
243+
new OnActivityResumedListener() {
244+
@Override
245+
public void onResumed(Activity activity) {
246+
task.setResult(
247+
getActivityWithIgnoredClass(activity, getPreviousActivity(), classToIgnore));
248+
removeOnActivityResumedListener(this);
249+
}
250+
});
251+
252+
return task.getTask();
253+
}
252254

253-
return task.getTask();
255+
@Nullable
256+
private Activity getPreviousActivity() {
257+
synchronized (lock) {
258+
return previousActivity;
254259
}
255260
}
256261

0 commit comments

Comments
 (0)