Responding to feedback part1

Manny Jimenez · Manny Jimenez · commit d30d7c2cdcc2 · 2021-12-08T10:31:55.000-05:00
diff --git a/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/SignInResultActivity.java b/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/SignInResultActivity.java
@@ -22,7 +22,7 @@
  * Activity opened through Deep Link when returning from web signIn flow. SignIn task is successful
  * when SignInResultActivity is created.
  */
-class SignInResultActivity extends AppCompatActivity {
+public class SignInResultActivity extends AppCompatActivity {
   private static final String TAG = "SignInResultActivity:";
 
   public SignInResultActivity() {}
diff --git a/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/UpdateAabClient.java b/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/UpdateAabClient.java
@@ -70,7 +70,7 @@ void onActivityStarted(Activity activity) {
     this.tryCancelAabUpdateTask();
   }
 
-  public UpdateTaskImpl updateAab(@NonNull AppDistributionReleaseInternal newRelease) {
+  UpdateTaskImpl updateAab(@NonNull AppDistributionReleaseInternal newRelease) {
     synchronized (updateAabLock) {
       if (cachedUpdateTask != null && !cachedUpdateTask.isComplete()) {
         return cachedUpdateTask;
diff --git a/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/UpdateApkClient.java b/firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/UpdateApkClient.java
@@ -70,7 +70,7 @@ public UpdateApkClient(
     this.installApkClient = installApkClient;
   }
 
-  public UpdateTaskImpl updateApk(
+  UpdateTaskImpl updateApk(
       @NonNull AppDistributionReleaseInternal newRelease, boolean showDownloadNotificationManager) {
     synchronized (updateTaskLock) {
       if (cachedUpdateTask != null && !cachedUpdateTask.isComplete()) {

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ void onActivityStarted(Activity activity) {`
`70`	`70`	`this.tryCancelAabUpdateTask();`
`71`	`71`	`}`
`72`	`72`
`73`		`- public UpdateTaskImpl updateAab(@NonNull AppDistributionReleaseInternal newRelease) {`
	`73`	`+ UpdateTaskImpl updateAab(@NonNull AppDistributionReleaseInternal newRelease) {`
`74`	`74`	`synchronized (updateAabLock) {`
`75`	`75`	`if (cachedUpdateTask != null && !cachedUpdateTask.isComplete()) {`
`76`	`76`	`return cachedUpdateTask;`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public UpdateApkClient(`
`70`	`70`	`this.installApkClient = installApkClient;`
`71`	`71`	`}`
`72`	`72`
`73`		`- public UpdateTaskImpl updateApk(`
	`73`	`+ UpdateTaskImpl updateApk(`
`74`	`74`	`@NonNull AppDistributionReleaseInternal newRelease, boolean showDownloadNotificationManager) {`
`75`	`75`	`synchronized (updateTaskLock) {`
`76`	`76`	`if (cachedUpdateTask != null && !cachedUpdateTask.isComplete()) {`