Use the equals

Author: samedson

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt

@@ -25,7 +25,7 @@ import com.google.firebase.ktx.app
 
 class FirebaseSessions internal constructor(firebaseApp: FirebaseApp) {
 
-  private val sessionGenerator = SessionGenerator(true)
+  private val sessionGenerator = SessionGenerator(collectEvents = true)
 
   init {
     val sessionInitiator = SessionInitiator(WallClock::elapsedRealtime, this::initiateSessionStart)

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionGenerator.kt

@@ -26,7 +26,7 @@ import java.util.UUID
 internal data class SessionInfo(
   val sessionId: String,
   val firstSessionId: String,
-  val shouldDispatchEvents: Boolean,
+  val collectEvents: Boolean,
   val sessionIndex: Int,
 )
 
@@ -54,7 +54,13 @@ internal class SessionGenerator(collectEvents: Boolean) {
 
     sessionIndex += 1
 
-    thisSession = SessionInfo(newSessionId, firstSessionId, collectEvents, sessionIndex)
+    thisSession =
+      SessionInfo(
+        sessionId = newSessionId,
+        firstSessionId = firstSessionId,
+        collectEvents = collectEvents,
+        sessionIndex = sessionIndex
+      )
   }
 
   val currentSession: SessionInfo

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/SessionGeneratorTest.kt

@@ -38,33 +38,33 @@ class SessionGeneratorTest {
   // ensures it has consistent behavior.
   @Test
   fun currentSession_beforeGenerateReturnsDefault() {
-    val sessionGenerator = SessionGenerator(false)
+    val sessionGenerator = SessionGenerator(collectEvents = false)
 
     assertThat(sessionGenerator.currentSession.sessionId).isEqualTo("")
     assertThat(sessionGenerator.currentSession.firstSessionId).isEqualTo("")
-    assertThat(sessionGenerator.currentSession.shouldDispatchEvents).isEqualTo(false)
+    assertThat(sessionGenerator.currentSession.collectEvents).isEqualTo(false)
     assertThat(sessionGenerator.currentSession.sessionIndex).isEqualTo(-1)
   }
 
   @Test
   fun generateNewSessionID_generatesValidSessionInfo() {
-    val sessionGenerator = SessionGenerator(true)
+    val sessionGenerator = SessionGenerator(collectEvents = true)
 
     sessionGenerator.generateNewSession()
 
     assertThat(isValidSessionId(sessionGenerator.currentSession.sessionId)).isEqualTo(true)
     assertThat(isValidSessionId(sessionGenerator.currentSession.firstSessionId)).isEqualTo(true)
     assertThat(sessionGenerator.currentSession.firstSessionId)
       .isEqualTo(sessionGenerator.currentSession.sessionId)
-    assertThat(sessionGenerator.currentSession.shouldDispatchEvents).isEqualTo(true)
+    assertThat(sessionGenerator.currentSession.collectEvents).isEqualTo(true)
     assertThat(sessionGenerator.currentSession.sessionIndex).isEqualTo(0)
   }
 
   // Ensures that generating a Session ID multiple times results in the fist
   // Session ID being set in the firstSessionId field
   @Test
   fun generateNewSessionID_incrementsSessionIndex_keepsFirstSessionId() {
-    val sessionGenerator = SessionGenerator(true)
+    val sessionGenerator = SessionGenerator(collectEvents = true)
 
     sessionGenerator.generateNewSession()