Skip to content

Commit de360e2

Browse files
committed
add more unit tests orderby field normalization
1 parent 6bb2c37 commit de360e2

File tree

1 file changed

+42
-0
lines changed
  • firebase-firestore/src/test/java/com/google/firebase/firestore/core

1 file changed

+42
-0
lines changed

firebase-firestore/src/test/java/com/google/firebase/firestore/core/QueryTest.java

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,7 @@ public void testImplicitOrderByInMultipleInequality() {
627627
orderBy(KEY_FIELD_NAME, "asc")),
628628
baseQuery
629629
.filter(filter("a", "<", 5))
630+
.filter(filter("a", ">=", 5))
630631
.filter(filter("aa", "<", 5))
631632
.filter(filter("b", "<", 5))
632633
.filter(filter("A", "<", 5))
@@ -701,6 +702,47 @@ public void testImplicitOrderByInMultipleInequality() {
701702
orFilters(filter("b", ">=", 1), filter("c", "<=", 1)),
702703
orFilters(filter("d", "<=", 1), filter("e", "==", 1))))
703704
.getOrderBy());
705+
706+
// OrderBy
707+
assertEquals(
708+
asList(
709+
orderBy("z", "asc"),
710+
orderBy("a", "asc"),
711+
orderBy("b", "asc"),
712+
orderBy(KEY_FIELD_NAME, "asc")),
713+
baseQuery
714+
.filter(filter("b", "<", 5))
715+
.filter(filter("a", "<", 5))
716+
.filter(filter("z", "<", 5))
717+
.orderBy(orderBy("z"))
718+
.getOrderBy());
719+
720+
// last explicit order by direction
721+
assertEquals(
722+
asList(
723+
orderBy("z", "desc"),
724+
orderBy("a", "desc"),
725+
orderBy("b", "desc"),
726+
orderBy(KEY_FIELD_NAME, "desc")),
727+
baseQuery
728+
.filter(filter("b", "<", 5))
729+
.filter(filter("a", "<", 5))
730+
.orderBy(orderBy("z", "desc"))
731+
.getOrderBy());
732+
733+
assertEquals(
734+
asList(
735+
orderBy("z", "desc"),
736+
orderBy("c", "asc"),
737+
orderBy("a", "asc"),
738+
orderBy("b", "asc"),
739+
orderBy(KEY_FIELD_NAME, "asc")),
740+
baseQuery
741+
.filter(filter("b", "<", 5))
742+
.filter(filter("a", "<", 5))
743+
.orderBy(orderBy("z", "desc"))
744+
.orderBy(orderBy("c"))
745+
.getOrderBy());
704746
}
705747

706748
@Test

0 commit comments

Comments
 (0)