Only allow one feedback flow to be active

Author: lfkellogg

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java

@@ -46,6 +46,7 @@
 import com.google.firebase.appdistribution.UpdateStatus;
 import com.google.firebase.appdistribution.UpdateTask;
 import java.util.concurrent.Executor;
+import java.util.concurrent.atomic.AtomicBoolean;
 
 /**
  * This class is the "real" implementation of the Firebase App Distribution API which should only be
@@ -87,6 +88,8 @@ class FirebaseAppDistributionImpl implements FirebaseAppDistribution {
   private TaskCompletionSource<Void> showSignInDialogTask = null;
   private TaskCompletionSource<Void> showUpdateDialogTask = null;
 
+  private AtomicBoolean feedbackInProgress = new AtomicBoolean(false);
+
   @VisibleForTesting
   FirebaseAppDistributionImpl(
       @NonNull FirebaseApp firebaseApp,
@@ -318,6 +321,12 @@ public void startFeedback(int infoTextResourceId) {
 
   @Override
   public void startFeedback(@NonNull CharSequence infoText) {
+    if (!feedbackInProgress.compareAndSet(/* expect= */ false, /* update= */ true)) {
+      LogWrapper.getInstance()
+          .i("Ignoring startFeedback() call because feedback is already in progress");
+      return;
+    }
+    LogWrapper.getInstance().i("Starting feedback");
     screenshotTaker
         .takeScreenshot()
         .addOnFailureListener(
@@ -349,7 +358,10 @@ public void startFeedback(@NonNull CharSequence infoText, @Nullable Uri screensh
             taskExecutor,
             releaseName -> launchFeedbackActivity(releaseName, infoText, screenshotUri))
         .addOnFailureListener(
-            taskExecutor, e -> LogWrapper.getInstance().e("Failed to launch feedback flow", e));
+            e -> {
+              LogWrapper.getInstance().e("Failed to launch feedback flow", e);
+              feedbackInProgress.set(false);
+            });
   }
 
   private Task<Void> launchFeedbackActivity(
@@ -412,10 +424,13 @@ void onActivityDestroyed(@NonNull Activity activity) {
       dialogHostActivity = null;
     }
 
-    // If the feedback activity finishes, clean up the screenshot that was taken before starting
-    // the activity. If this does not happen for some reason it will be cleaned up the next time
-    // before taking a new screenshot.
     if (activity instanceof FeedbackActivity) {
+      LogWrapper.getInstance().i("FeedbackActivity destroyed");
+      feedbackInProgress.set(false);
+
+      // If the feedback activity finishes, clean up the screenshot that was taken before starting
+      // the activity. If this does not happen for some reason it will be cleaned up the next time
+      // before taking a new screenshot.
       screenshotTaker.deleteScreenshot();
     }
   }