Skip to content

Commit df34a52

Browse files
committed
dataconnect.yml: use set -xv instead of manually echoing information
1 parent 02beb1e commit df34a52

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

.github/workflows/dataconnect.yml

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ jobs:
174174
id: data-connect-emulator
175175
run: |
176176
set -euo pipefail
177-
set -x
177+
set -xv
178178
179179
echo 'emulator.postgresConnectionUrl=postgresql://postgres:[email protected]:5432?sslmode=disable' > firebase-dataconnect/dataconnect.local.properties
180180
@@ -183,33 +183,29 @@ jobs:
183183
:firebase-dataconnect:connectors:runDebugDataConnectEmulator \
184184
>firebase.emulator.dataconnect.log 2>&1 &
185185
186-
readonly FIREBASE_DATA_CONNECT_EMULATOR_PID=$!
187-
echo "FIREBASE_DATA_CONNECT_EMULATOR_PID=$FIREBASE_DATA_CONNECT_EMULATOR_PID"
188-
echo "FIREBASE_DATA_CONNECT_EMULATOR_PID=$FIREBASE_DATA_CONNECT_EMULATOR_PID" >> "$GITHUB_ENV"
186+
echo "FIREBASE_DATA_CONNECT_EMULATOR_PID=$!" >> "$GITHUB_ENV"
189187
190188
- name: Firebase Auth Emulator Start
191189
id: firebase-auth-emulator
192190
run: |
193191
set -euo pipefail
194-
set -x
192+
set -xv
193+
195194
cd firebase-dataconnect/emulator
196195
${{ env.FDC_FIREBASE_COMMAND }} emulators:start --only=auth >firebase.emulator.auth.log 2>&1 &
197196
198-
readonly FIREBASE_AUTH_EMULATOR_PID=$!
199-
echo "FIREBASE_AUTH_EMULATOR_PID=$FIREBASE_AUTH_EMULATOR_PID"
200-
echo "FIREBASE_AUTH_EMULATOR_PID=$FIREBASE_AUTH_EMULATOR_PID" >> "$GITHUB_ENV"
197+
echo "FIREBASE_AUTH_EMULATOR_PID=$!" >> "$GITHUB_ENV"
201198
202199
- name: Logcat Log Capture Start
203200
id: logcat-capture
204201
continue-on-error: true
205202
run: |
206203
set -euo pipefail
207-
set -v
204+
set -xv
208205
209206
"$ANDROID_HOME/platform-tools/adb" logcat >logcat.log 2>&1 &
210-
readonly LOGCAT_PID=$!
211-
echo "LOGCAT_PID=$LOGCAT_PID"
212-
echo "LOGCAT_PID=$LOGCAT_PID" >> "$GITHUB_ENV"
207+
208+
echo "LOGCAT_PID=$!" >> "$GITHUB_ENV"
213209
214210
- name: Gradle connectedCheck
215211
id: connectedCheck

0 commit comments

Comments
 (0)